Page MenuHomePhabricator
Differential D15027

Add link to Herald Transaction when blocking pushes
ClosedPublic
Actions

Authored by avivey on Jan 15 2016, 2:59 AM.
Tags
None
Referenced Files
F15433862: D15027.diff
Tue, Mar 25, 12:56 AM
F15422503: D15027.id36285.diff
Sat, Mar 22, 8:53 AM
F15421545: D15027.id36286.diff
Sat, Mar 22, 12:42 AM
F15416860: D15027.id.diff
Thu, Mar 20, 2:05 PM
F15413901: D15027.diff
Wed, Mar 19, 9:54 PM
F15404288: D15027.id36286.diff
Tue, Mar 18, 7:08 AM
F15383262: D15027.id.diff
Fri, Mar 14, 3:59 PM
F15348443: D15027.id36286.diff
Mon, Mar 10, 2:30 PM
View All Files
Subscribers
epriestley

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess
Commits
Restricted Diffusion Commit
rP98d237067246: Add link to Herald Transaction when blocking pushes
Summary

Ref T9719.

Test Plan

Tried to push, get dragon and a link.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avivey updated this revision to Diff 36285.Jan 15 2016, 2:59 AM
avivey retitled this revision from to Add link to Herald Transaction when blocking pushes.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey added a task: T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 15 2016, 2:59 AM
Herald added a subscriber: epriestley. · View Herald Transcript
epriestley accepted this revision.Jan 15 2016, 2:59 AM
epriestley added a reviewer: epriestley.
This revision is now accepted and ready to land.Jan 15 2016, 2:59 AM
Closed by commit rP98d237067246: Add link to Herald Transaction when blocking pushes (authored by avivey, committed by avivey). · Explain WhyJan 15 2016, 3:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
engine/
13 lines

Diff 36286

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Loading...
Phabricator · Built by Phacility