Differential D15018

Prepare Profile Panels for adoption in other applications
ClosedPublic
Actions

Authored by epriestley on Jan 14 2016, 2:02 PM.

Tags

None

Referenced Files

	F13145753: D15018.diff
	Fri, May 3, 9:17 AM

	Unknown Object (File)
	Fri, Apr 26, 10:09 AM

	Unknown Object (File)
	Fri, Apr 26, 5:26 AM

	Unknown Object (File)
	Fri, Apr 26, 5:26 AM

	Unknown Object (File)
	Fri, Apr 26, 4:59 AM

	Unknown Object (File)
	Thu, Apr 25, 2:55 AM

	Unknown Object (File)
	Thu, Apr 11, 10:26 AM

	Unknown Object (File)
	Mon, Apr 8, 7:11 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10054: Define product direction for Project/Profile UIs

Commits

Restricted Diffusion Commit
rP2a6b2dbbfdf1: Prepare Profile Panels for adoption in other applications

Summary

Ref T10054. Take specialization off the objects and put it on Engine subclasses instead. One reason for this is that certain objects (like users) might have multiple different sets of panels in the future (e.g., their user profile and their home page).

Test Plan

No user-visible changes.
PanelEngine no longer has any hardcoded "project" stuff.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36271.Jan 14 2016, 2:02 PM

epriestley retitled this revision from to Prepare Profile Panels for adoption in other applications.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10054: Define product direction for Project/Profile UIs.

chad accepted this revision.Jan 14 2016, 9:22 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 14 2016, 9:22 PM

Closed by commit rP2a6b2dbbfdf1: Prepare Profile Panels for adoption in other applications (authored by epriestley, committed by epriestley). · Explain WhyJan 15 2016, 5:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

applications/

project/

controller/

PhabricatorProjectController.php

2 lines

PhabricatorProjectPanelController.php

2 lines

engine/

PhabricatorProjectProfilePanelEngine.php

51 lines

storage/

PhabricatorProject.php

46 lines

search/

editor/

PhabricatorProfilePanelEditEngine.php

3 lines

engine/

PhabricatorProfilePanelEngine.php

21 lines

interface/

PhabricatorProfilePanelInterface.php

profilepanel/

PhabricatorLinkProfilePanel.php

3 lines

PhabricatorProfilePanel.php

3 lines

storage/

PhabricatorProfilePanelConfiguration.php

5 lines

Diff 36303

src/__phutil_library_map__.php

Loading...

src/applications/project/controller/PhabricatorProjectController.php

Loading...

src/applications/project/controller/PhabricatorProjectPanelController.php

Loading...

src/applications/project/engine/PhabricatorProjectProfilePanelEngine.php

Loading...

src/applications/project/storage/PhabricatorProject.php

Loading...

src/applications/search/editor/PhabricatorProfilePanelEditEngine.php

Loading...

src/applications/search/engine/PhabricatorProfilePanelEngine.php

Loading...

src/applications/search/interface/PhabricatorProfilePanelInterface.php

Loading...

src/applications/search/profilepanel/PhabricatorLinkProfilePanel.php

Loading...

src/applications/search/profilepanel/PhabricatorProfilePanel.php

Loading...

src/applications/search/storage/PhabricatorProfilePanelConfiguration.php

Loading...