HomePhabricator

Make profile menu full-height

Description

Make profile menu full-height

Summary:
Ref T10054. This makes the profile menu full-height. It uses two pieces of dark magic:

  • calc(), which allows you to do math in CSS.
  • The vh unit, which is CSS for "viewport height".

Apparently this kind of stuff just works now? CSS got good at some point?

Test Plan:

  • Page looks correct in Safari, Chrome, Firefox.
  • Checked caniuse.com for vh and calc(), saw they're supported?

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10054

Differential Revision: https://secure.phabricator.com/D15017

Details

Provenance
epriestleyAuthored on Jan 14 2016, 1:29 AM
epriestleyPushed on Jan 15 2016, 5:12 PM
Reviewer
chad
Differential Revision
D15017: Make profile menu full-height
Parents
rP468031d1fd77: Rough initial cut of profile new profile menu
Branches
Unknown
Tags
Unknown
Tasks
T10054: Define product direction for Project/Profile UIs
Build Status
Buildable 10137
Build 12297: Run Core Tests