Page MenuHomePhabricator
Differential D15006

Make hashtags at the end of bolded text render properly
ClosedPublic
Actions

Authored by epriestley on Jan 12 2016, 5:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 8, 4:52 PM
Unknown Object (File)
Sat, Dec 7, 9:10 AM
Unknown Object (File)
Thu, Dec 5, 9:20 AM
Unknown Object (File)
Sun, Dec 1, 2:30 PM
Unknown Object (File)
Tue, Nov 19, 4:42 PM
Unknown Object (File)
Nov 19 2024, 8:46 AM
Unknown Object (File)
Nov 11 2024, 12:05 PM
Unknown Object (File)
Nov 10 2024, 3:57 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10096: Incorrect remarkup rendering of bold text, that contains hashtag (#)
Commits
Restricted Diffusion Commit
rPd57c1d6ce2f5: Make hashtags at the end of bolded text render properly
Summary

Fixes T10096. The ** was being parsed as part of the hashtag, so **#asdf** interpreted #asdf** as a hashtag.

Test Plan

Unit test; bolded stuff with hashy contents.

Diff Detail

Repository
rP Phabricator
Branch
boldhash
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10082
Build 12212: Run Core Tests
Build 12211: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36248.Jan 12 2016, 5:29 PM
epriestley updated this revision to Diff 36249.
epriestley retitled this revision from to Make hashtags at the end of bolded text render properly.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10096: Incorrect remarkup rendering of bold text, that contains hashtag (#).
  • Smaller patch.
src/applications/project/remarkup/ProjectRemarkupRule.php
39

These are for **bold**, //italics// and ~~strikethru~~.

chad accepted this revision.Jan 12 2016, 5:48 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 12 2016, 5:48 PM
Closed by commit rPd57c1d6ce2f5: Make hashtags at the end of bolded text render properly (authored by epriestley, committed by epriestley). · Explain WhyJan 12 2016, 6:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
project/
remarkup/
6 lines
__tests__/
10 lines

Diff 36248

View Options

src/applications/project/remarkup/ProjectRemarkupRule.php

Loading...
View Options

src/applications/project/remarkup/__tests__/ProjectRemarkupRuleTestCase.php

Loading...
Phabricator · Built by Phacility