Page MenuHomePhabricator

Make hashtags at the end of bolded text render properly
ClosedPublic

Authored by epriestley on Jan 12 2016, 5:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 15, 4:25 PM
Unknown Object (File)
Fri, Mar 15, 4:13 PM
Unknown Object (File)
Fri, Mar 15, 3:32 PM
Unknown Object (File)
Fri, Mar 15, 2:48 PM
Unknown Object (File)
Fri, Mar 15, 1:24 PM
Unknown Object (File)
Fri, Mar 15, 1:17 PM
Unknown Object (File)
Tue, Mar 12, 4:44 PM
Unknown Object (File)
Wed, Mar 6, 3:42 PM
Subscribers
None

Details

Summary

Fixes T10096. The ** was being parsed as part of the hashtag, so **#asdf** interpreted #asdf** as a hashtag.

Test Plan

Unit test; bolded stuff with hashy contents.

Diff Detail

Repository
rP Phabricator
Branch
boldhash
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10082
Build 12212: Run Core Tests
Build 12211: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36249.
epriestley retitled this revision from to Make hashtags at the end of bolded text render properly.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Smaller patch.
src/applications/project/remarkup/ProjectRemarkupRule.php
39

These are for **bold**, //italics// and ~~strikethru~~.

chad edited edge metadata.
This revision is now accepted and ready to land.Jan 12 2016, 5:48 PM
This revision was automatically updated to reflect the committed changes.