Page MenuHomePhabricator

Make hashtags at the end of bolded text render properly
ClosedPublic

Authored by epriestley on Jan 12 2016, 5:29 PM.

Details

Summary

Fixes T10096. The ** was being parsed as part of the hashtag, so **#asdf** interpreted #asdf** as a hashtag.

Test Plan

Unit test; bolded stuff with hashy contents.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36249.
epriestley retitled this revision from to Make hashtags at the end of bolded text render properly.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Smaller patch.
src/applications/project/remarkup/ProjectRemarkupRule.php
35

These are for **bold**, //italics// and ~~strikethru~~.

chad edited edge metadata.
This revision is now accepted and ready to land.Jan 12 2016, 5:48 PM
This revision was automatically updated to reflect the committed changes.