Page MenuHomePhabricator

Fix excessively harsh validation of certain complex configuration
ClosedPublic

Authored by epriestley on Jan 11 2016, 10:18 PM.
Tags
None
Referenced Files
F14370824: D14998.id.diff
Fri, Dec 20, 6:26 PM
Unknown Object (File)
Thu, Dec 19, 4:43 PM
Unknown Object (File)
Thu, Dec 12, 2:15 PM
Unknown Object (File)
Tue, Dec 10, 10:31 PM
Unknown Object (File)
Wed, Dec 4, 7:55 AM
Unknown Object (File)
Mon, Dec 2, 11:20 PM
Unknown Object (File)
Mon, Dec 2, 11:20 PM
Unknown Object (File)
Mon, Dec 2, 11:19 PM
Subscribers
None

Details

Summary

See IRC. We're supposed to repair configuration, but if custom validators throw a generic Exception or use PhutilTypeSpec to do a check, we may explode way harder than we intend to.

Instead, soften these exceptions into validation exceptions so we repair configuration, raise a setup issue, and continue.

Test Plan

Screen Shot 2016-01-11 at 2.16.15 PM.png (1×3 px, 385 KB)

Diff Detail

Repository
rP Phabricator
Branch
configcheck
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10066
Build 12186: Run Core Tests
Build 12185: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix excessively harsh validation of certain complex configuration.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 11 2016, 10:19 PM
epriestley edited edge metadata.
  • "convert" instead of "conver"
This revision was automatically updated to reflect the committed changes.