Paths

Table of Contentst

Differential D14984

Give `<hr />` in remarkup `clear: both`
ClosedPublic
Actions

Authored by epriestley on Jan 10 2016, 2:21 PM.

Tags

None

Referenced Files

	F13170974: D14984.diff
	Tue, May 7, 9:54 AM

	Unknown Object (File)
	Fri, May 3, 9:45 AM

	Unknown Object (File)
	Thu, Apr 25, 3:43 PM

	Unknown Object (File)
	Thu, Apr 25, 2:39 AM

	Unknown Object (File)
	Thu, Apr 11, 10:43 AM

	Unknown Object (File)
	Thu, Apr 11, 8:16 AM

	Unknown Object (File)
	Apr 1 2024, 12:24 AM

	Unknown Object (File)
	Mar 31 2024, 2:04 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10110: Floating images in Phriction can make everything else afterwards float... forever

Commits

Restricted Diffusion Commit
rP01fba3432707: Give `<hr />` in remarkup `clear: both`

Summary

Test Plan

Before:

Screen Shot 2016-01-10 at 6.20.18 AM.png (787×1 px, 165 KB)

After:

Screen Shot 2016-01-10 at 6.20.29 AM.png (819×1 px, 166 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36195.Jan 10 2016, 2:21 PM

epriestley retitled this revision from to Give `<hr />` in remarkup `clear: both`.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10110: Floating images in Phriction can make everything else afterwards float... forever.

Herald edited edge metadata. · View Herald TranscriptJan 10 2016, 2:21 PM

epriestley mentioned this in T10110: Floating images in Phriction can make everything else afterwards float... forever.Jan 10 2016, 3:56 PM

Also clear all headers that have rules in CSS. Not sure Remarkup can actually generate all of these, but the rules are narrow.

Herald edited edge metadata. · View Herald TranscriptJan 10 2016, 4:01 PM

It's probably safest to just do the hr when I think about it. We're also limiting layout options here by putting it on all headers. I was mostly suggesting just the largest header.

Yeah, that's reasonable.

Just <hr />.

chad accepted this revision.Jan 10 2016, 5:27 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 10 2016, 5:27 PM

Closed by commit rP01fba3432707: Give `<hr />` in remarkup `clear: both` (authored by epriestley, committed by epriestley). · Explain WhyJan 10 2016, 5:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

6 lines

webroot/

rsrc/

css/

core/

1 line

Diff 36202

resources/celerity/map.php

Loading...

webroot/rsrc/css/core/remarkup.css

Loading...