Fixes T2450. If we spend more than 15 seconds in blame, just cut it off.
Details
Details
- Reviewers
chad - Maniphest Tasks
- T2450: Build a blame cache
- Commits
- Restricted Diffusion Commit
rP438100691d42: Don't let blame run for longer than 15 seconds
- Changed timeout to 0.01 seconds.
- Did blame on a non-highlighted file, got no blame, saw warning.
- Did blame on a highlighted file, got no blame.
- Note: you don't get a warning here because of Ajax stuff. It'd be kind of tricky to add and doesn't seem like a big deal so I'm planning to leave it as-is for now.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- blame7
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 9976 Build 12054: Run Core Tests Build 12053: arc lint + arc unit
Event Timeline
Comment Actions
- This and prior commits in the sequence (see T2450) should generally improve the behavior you ran into.
- We will no longer try to generate blame data for very large files (>256KB of text).
- We no longer try to highlight very large files.
- We will no longer spend more than 15 seconds trying to generate blame data for files we do try to pull it for.
- Generation of blame data is now faster and cached better; cache hits are on the order of tens of milliseconds instead of multiple seconds.
- Rendering of blame data is now much better in extreme cases (although, broadly speaking, we now decline to try to pull the data in extreme cases).