Page MenuHomePhabricator
Differential D14948

Modernize Diffusion lint controllers
ClosedPublic
Actions

Authored by epriestley on Jan 5 2016, 8:29 PM.
Tags
None
Referenced Files
F13146985: D14948.diff
Fri, May 3, 11:45 AM
Unknown Object (File)
Thu, Apr 25, 3:21 AM
Unknown Object (File)
Fri, Apr 19, 4:03 PM
Unknown Object (File)
Sun, Apr 14, 9:36 AM
Unknown Object (File)
Mar 23 2024, 5:45 PM
Unknown Object (File)
Mar 23 2024, 5:45 PM
Unknown Object (File)
Mar 23 2024, 5:45 PM
Unknown Object (File)
Mar 22 2024, 10:35 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4245: Make repository URIs slightly prettier
Commits
Restricted Diffusion Commit
rP38f2008e68b4: Modernize Diffusion lint controllers
Summary

Ref T4245. On their best day these don't work all that well, but I'm pretty sure I didn't make anything worse.

Test Plan
  • Viewed global lint.
  • Viewed lint for a repository.
  • Viewed lint details for a particular message.

Diff Detail

Repository
rP Phabricator
Branch
call9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9935
Build 11994: Run Core Tests
Build 11993: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36110.Jan 5 2016, 8:29 PM
epriestley retitled this revision from to Modernize Diffusion lint controllers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4245: Make repository URIs slightly prettier.
chad accepted this revision.Jan 5 2016, 9:23 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 5 2016, 9:23 PM
Closed by commit rP38f2008e68b4: Modernize Diffusion lint controllers (authored by epriestley, committed by epriestley). · Explain WhyJan 5 2016, 10:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
diffusion/
controller/
287 lines
request/
5 lines

Diff 36110

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionLintController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionLintDetailsController.php

Loading...
View Options

src/applications/diffusion/request/DiffusionRequest.php

Loading...
Phabricator · Built by Phacility