Page MenuHomePhabricator
Differential D14941

Modernize tag and branch controllers in Diffusion
ClosedPublic
Actions

Authored by epriestley on Jan 5 2016, 1:12 PM.
Tags
None
Referenced Files
F15531233: D14941.id36117.diff
Wed, Apr 23, 10:16 AM
F15523338: D14941.diff
Mon, Apr 21, 12:43 AM
F15491423: D14941.id36117.diff
Sat, Apr 12, 3:17 AM
F15491026: D14941.id.diff
Fri, Apr 11, 10:41 PM
F15489352: D14941.id36093.diff
Fri, Apr 11, 8:12 AM
F15485922: D14941.diff
Thu, Apr 10, 3:37 AM
F15460257: D14941.id36093.diff
Mon, Mar 31, 9:17 PM
F15460256: D14941.id.diff
Mon, Mar 31, 9:17 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4245: Make repository URIs slightly prettier
Commits
Restricted Diffusion Commit
rP7de17fb75ec3: Modernize tag and branch controllers in Diffusion
Summary

Ref T4245. Prepares these controllers to accept alternate identifers, plus minor spacing and layout fixes.

Test Plan

Viewed tags, viewed branches.

Diff Detail

Repository
rP Phabricator
Branch
call3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9917
Build 11967: Run Core Tests
Build 11966: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36093.Jan 5 2016, 1:12 PM
epriestley retitled this revision from to Modernize tag and branch controllers in Diffusion.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4245: Make repository URIs slightly prettier.
chad accepted this revision.Jan 5 2016, 3:22 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 5 2016, 3:22 PM
Closed by commit rP7de17fb75ec3: Modernize tag and branch controllers in Diffusion (authored by epriestley, committed by epriestley). · Explain WhyJan 5 2016, 9:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
application/
2 lines
controller/
37 lines
27 lines
39 lines
request/
6 lines

Diff 36093

View Options

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBranchTableController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionTagListController.php

Loading...
View Options

src/applications/diffusion/request/DiffusionRequest.php

Loading...
Phabricator · Built by Phacility