Page MenuHomePhabricator
Differential D14931

Separate external editor integration from callsigns
ClosedPublic
Actions

Authored by epriestley on Jan 2 2016, 7:57 PM.
Tags
None
Referenced Files
F13157736: D14931.diff
Sun, May 5, 1:55 PM
Unknown Object (File)
Thu, Apr 25, 12:04 AM
Unknown Object (File)
Mon, Apr 22, 3:19 AM
Unknown Object (File)
Fri, Apr 19, 4:01 PM
Unknown Object (File)
Thu, Apr 11, 8:21 AM
Unknown Object (File)
Mon, Apr 8, 10:38 AM
Unknown Object (File)
Mon, Apr 8, 7:50 AM
Unknown Object (File)
Mar 31 2024, 10:50 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4245: Make repository URIs slightly prettier
Commits
Restricted Diffusion Commit
rPbe5b89687e37: Separate external editor integration from callsigns
Summary

Ref T4245. Pass the whole repository in so it can do something else in a future change.

Test Plan

Loaded changesets in Diffusion.

Diff Detail

Repository
rP Phabricator
Branch
callsign8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9898
Build 11937: Run Core Tests
Build 11936: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36074.Jan 2 2016, 7:57 PM
epriestley retitled this revision from to Separate external editor integration from callsigns.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4245: Make repository URIs slightly prettier.
chad accepted this revision.Jan 3 2016, 4:52 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 3 2016, 4:52 AM
Closed by commit rPbe5b89687e37: Separate external editor integration from callsigns (authored by epriestley, committed by epriestley). · Explain WhyJan 4 2016, 2:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
console/
plugin/
2 lines
differential/
view/
3 lines
diffusion/
controller/
5 lines
people/
storage/
12 lines
view/
widget/
8 lines

Diff 36074

View Options

src/applications/console/plugin/DarkConsoleErrorLogPlugin.php

Loading...
View Options

src/applications/differential/view/DifferentialChangesetListView.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseFileController.php

Loading...
View Options

src/applications/people/storage/PhabricatorUser.php

Loading...
View Options

src/view/widget/AphrontStackTraceView.php

Loading...
Phabricator · Built by Phacility