Page MenuHomePhabricator
Differential D14930

Remove `diffusion.getcommits` Conduit API method
ClosedPublic
Actions

Authored by epriestley on Jan 2 2016, 7:52 PM.
Tags
None
Referenced Files
F14344201: D14930.id36082.diff
Thu, Dec 19, 12:35 AM
Unknown Object (File)
Wed, Dec 4, 2:52 AM
Unknown Object (File)
Thu, Nov 28, 7:17 AM
Unknown Object (File)
Wed, Nov 27, 6:15 PM
Unknown Object (File)
Wed, Nov 27, 3:51 AM
Unknown Object (File)
Fri, Nov 22, 8:57 AM
Unknown Object (File)
Tue, Nov 19, 10:12 PM
Unknown Object (File)
Nov 15 2024, 5:53 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4245: Make repository URIs slightly prettier
Commits
Restricted Diffusion Commit
rPb1388c5ca157: Remove `diffusion.getcommits` Conduit API method
Summary

Ref T4245. This was obsoleted long ago and has no callers in Phabricator or Arcanist.

Also some minor cleanup.

Test Plan

grep for callers everywhere.

Diff Detail

Repository
rP Phabricator
Branch
callsign7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9897
Build 11935: Run Core Tests
Build 11934: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36073.Jan 2 2016, 7:52 PM
epriestley retitled this revision from to Remove `diffusion.getcommits` Conduit API method.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4245: Make repository URIs slightly prettier.
chad accepted this revision.Jan 3 2016, 4:09 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 3 2016, 4:09 AM
Closed by commit rPb1388c5ca157: Remove `diffusion.getcommits` Conduit API method (authored by epriestley, committed by epriestley). · Explain WhyJan 4 2016, 2:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 36073

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/conduit/DiffusionGetCommitsConduitAPIMethod.php

Loading...
View Options

src/applications/diffusion/view/DiffusionView.php

Loading...
View Options

src/applications/repository/phid/PhabricatorRepositoryRepositoryPHIDType.php

Loading...
View Options

src/applications/repository/worker/__tests__/PhabricatorChangeParserTestCase.php

Loading...
View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Loading...
Phabricator · Built by Phacility