Differential D14928

Allow Conduit API methods in Diffusion to accept any repository identifier
ClosedPublic
Actions

Authored by epriestley on Jan 2 2016, 7:20 PM.

Details

Reviewers

chad

Maniphest Tasks

T4245: Make repository URIs slightly prettier

Commits

Restricted Diffusion Commit
rP9d84eb4c747d: Allow Conduit API methods in Diffusion to accept any repository identifier

Summary

Ref T4245. Broaden support to include "ABCD", "rABCD", "1234", "R1234", etc.

This doesn't change the old behavior, just accepts more stuff.

Test Plan

Browsed Diffusion.
Made various calls via API console.

Diff Detail

Repository

rP Phabricator

Branch

callsign5

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9894
Build 11929: Run Core Tests
Build 11928: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36070.Jan 2 2016, 7:20 PM

epriestley retitled this revision from to Allow Conduit API methods in Diffusion to accept any repository identifier.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T4245: Make repository URIs slightly prettier.

Fix an issue with juggling reposiories and identifiers.

chad accepted this revision.Jan 3 2016, 3:59 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 3 2016, 3:59 AM

Closed by commit rP9d84eb4c747d: Allow Conduit API methods in Diffusion to accept any repository identifier (authored by epriestley, committed by epriestley). · Explain WhyJan 4 2016, 2:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

conduit/

DiffusionQueryConduitAPIMethod.php

12 lines

request/

DiffusionRequest.php

100 lines

Diff 36070

View Options

src/applications/diffusion/conduit/DiffusionQueryConduitAPIMethod.php