Page MenuHomePhabricator

Clean up ProjectQuery when viewer is logged-out or omnipotent
ClosedPublic

Authored by epriestley on Dec 27 2015, 12:17 PM.
Tags
None
Referenced Files
F11396380: D14892.diff
Sun, Nov 27, 3:28 PM
Unknown Object (File)
Wed, Nov 16, 7:06 AM
Unknown Object (File)
Thu, Nov 10, 3:38 AM
Unknown Object (File)
Thu, Nov 10, 3:00 AM
Unknown Object (File)
Thu, Nov 10, 3:00 AM
Unknown Object (File)
Thu, Nov 10, 3:00 AM
Unknown Object (File)
Wed, Nov 2, 7:03 AM
Unknown Object (File)
Oct 15 2022, 1:40 AM
Subscribers
None

Details

Summary

Ref T10010. When the viewer is logged-out or omnipotent, we can skip this query.

(Currently we issue a silly query like src = X AND type = Y AND dst = '', which will never return results.)

Test Plan
  • Viewed projects as normal user and logged-out user.
  • Ran unit tests.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Clean up ProjectQuery when viewer is logged-out or omnipotent.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 27 2015, 3:00 PM
This revision was automatically updated to reflect the committed changes.