Paths

Table of Contentst

Differential D14892

Clean up ProjectQuery when viewer is logged-out or omnipotent
ClosedPublic
Actions

Authored by epriestley on Dec 27 2015, 12:17 PM.

Details

Reviewers

chad

Maniphest Tasks

T10010: Implement Subprojects

Commits

Restricted Diffusion Commit
rP77897ce86258: Clean up ProjectQuery when viewer is logged-out or omnipotent

Summary

Ref T10010. When the viewer is logged-out or omnipotent, we can skip this query.

(Currently we issue a silly query like src = X AND type = Y AND dst = '', which will never return results.)

Test Plan

Viewed projects as normal user and logged-out user.
Ran unit tests.

Diff Detail

Repository

rP Phabricator

Branch

sub5

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9812
Build 11807: Run Core Tests
Build 11806: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35989.Dec 27 2015, 12:17 PM

epriestley retitled this revision from to Clean up ProjectQuery when viewer is logged-out or omnipotent.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10010: Implement Subprojects.

chad accepted this revision.Dec 27 2015, 3:00 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 27 2015, 3:00 PM

Closed by commit rP77897ce86258: Clean up ProjectQuery when viewer is logged-out or omnipotent (authored by epriestley, committed by epriestley). · Explain WhyDec 27 2015, 5:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

query/

PhabricatorProjectQuery.php

24 lines

Diff 35989

View Options

src/applications/project/query/PhabricatorProjectQuery.php

Clean up ProjectQuery when viewer is logged-out or omnipotentClosedPublicActions