Paths

Table of Contentst

Clean up ProjectQuery when viewer is logged-out or omnipotent
ClosedPublic
Actions

Authored by epriestley on Dec 27 2015, 12:17 PM.

Tags

None

Referenced Files

	F18748236: D14892.id36000.diff
	Fri, Oct 3, 8:02 PM

	F18745141: D14892.id.diff
	Fri, Oct 3, 5:27 AM

	F18742531: D14892.diff
	Thu, Oct 2, 8:03 PM

	F18737514: D14892.id36000.diff
	Wed, Oct 1, 11:12 AM

	F18642632: D14892.diff
	Fri, Sep 19, 12:23 AM

	F18627416: D14892.id35989.diff
	Sep 16 2025, 3:57 AM

	F18622253: D14892.id35989.diff
	Sep 15 2025, 10:58 AM

	F18412095: D14892.id.diff
	Aug 30 2025, 6:19 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T10010: Implement Subprojects

Commits

Restricted Diffusion Commit
rP77897ce86258: Clean up ProjectQuery when viewer is logged-out or omnipotent

Summary

Ref T10010. When the viewer is logged-out or omnipotent, we can skip this query.

(Currently we issue a silly query like src = X AND type = Y AND dst = '', which will never return results.)

Test Plan

Viewed projects as normal user and logged-out user.
Ran unit tests.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35989.Dec 27 2015, 12:17 PM

epriestley retitled this revision from to Clean up ProjectQuery when viewer is logged-out or omnipotent.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10010: Implement Subprojects.

chad accepted this revision.Dec 27 2015, 3:00 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 27 2015, 3:00 PM

Closed by commit rP77897ce86258: Clean up ProjectQuery when viewer is logged-out or omnipotent (authored by epriestley, committed by epriestley). · Explain WhyDec 27 2015, 5:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

query/

PhabricatorProjectQuery.php

24 lines

Diff 36000

View Options

src/applications/project/query/PhabricatorProjectQuery.php

Clean up ProjectQuery when viewer is logged-out or omnipotentClosedPublicActions