Page MenuHomePhabricator

Simplify ProjectQuery handling of viewer membership
ClosedPublic

Authored by epriestley on Dec 23 2015, 11:59 AM.
Tags
None
Referenced Files
F11409733: D14859.diff
Tue, Dec 6, 4:33 PM
Unknown Object (File)
Tue, Nov 29, 8:33 PM
Unknown Object (File)
Tue, Nov 29, 8:33 PM
Unknown Object (File)
Tue, Nov 29, 8:33 PM
Unknown Object (File)
Fri, Nov 25, 5:23 PM
Unknown Object (File)
Sun, Nov 20, 9:00 AM
Unknown Object (File)
Wed, Nov 16, 5:46 PM
Unknown Object (File)
Wed, Nov 16, 7:09 AM
Subscribers
None

Details

Summary

Ref T10010. Currently, we do an unusual JOIN to make testing for viewer membership in projects a little cheaper.

This won't work as-is once we have subprojects, so standardize, simplify, and cover it with more tests for now. (I may be able to get a similar optimization later, but want a correct implementation first.)

Test Plan

This change should create no behavioral differences.

  • Added tests.
  • Ran tests.
  • Viewed projects.

Diff Detail

Repository
rP Phabricator
Branch
proj1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9743
Build 11697: Run Core Tests
Build 11696: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Simplify ProjectQuery handling of viewer membership.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 23 2015, 4:36 PM
This revision was automatically updated to reflect the committed changes.