Page MenuHomePhabricator

Simplify ProjectQuery handling of viewer membership
ClosedPublic

Authored by epriestley on Dec 23 2015, 11:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 13, 12:07 PM
Unknown Object (File)
Fri, Apr 12, 6:05 AM
Unknown Object (File)
Mon, Apr 1, 12:25 AM
Unknown Object (File)
Thu, Mar 28, 12:29 PM
Unknown Object (File)
Sun, Mar 24, 11:50 AM
Unknown Object (File)
Mar 5 2024, 3:44 PM
Unknown Object (File)
Mar 5 2024, 3:44 PM
Unknown Object (File)
Feb 20 2024, 2:20 AM
Subscribers
None

Details

Summary

Ref T10010. Currently, we do an unusual JOIN to make testing for viewer membership in projects a little cheaper.

This won't work as-is once we have subprojects, so standardize, simplify, and cover it with more tests for now. (I may be able to get a similar optimization later, but want a correct implementation first.)

Test Plan

This change should create no behavioral differences.

  • Added tests.
  • Ran tests.
  • Viewed projects.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Simplify ProjectQuery handling of viewer membership.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 23 2015, 4:36 PM
This revision was automatically updated to reflect the committed changes.