Page MenuHomePhabricator

Simplify ProjectQuery handling of viewer membership
ClosedPublic

Authored by epriestley on Dec 23 2015, 11:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 21, 8:53 PM
Unknown Object (File)
Mon, Sep 19, 7:32 PM
Unknown Object (File)
Sat, Sep 17, 4:39 PM
Unknown Object (File)
Sat, Sep 17, 8:17 AM
Unknown Object (File)
Fri, Sep 16, 8:04 PM
Unknown Object (File)
Sun, Aug 28, 7:39 AM
Unknown Object (File)
Aug 11 2022, 4:40 PM
Unknown Object (File)
Aug 8 2022, 6:06 PM
Subscribers
None

Details

Summary

Ref T10010. Currently, we do an unusual JOIN to make testing for viewer membership in projects a little cheaper.

This won't work as-is once we have subprojects, so standardize, simplify, and cover it with more tests for now. (I may be able to get a similar optimization later, but want a correct implementation first.)

Test Plan

This change should create no behavioral differences.

  • Added tests.
  • Ran tests.
  • Viewed projects.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Simplify ProjectQuery handling of viewer membership.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 23 2015, 4:36 PM
This revision was automatically updated to reflect the committed changes.