Page MenuHomePhabricator
Differential D14859

Simplify ProjectQuery handling of viewer membership
ClosedPublic
Actions

Authored by epriestley on Dec 23 2015, 11:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 11, 10:51 PM
Unknown Object (File)
Sun, Feb 9, 12:15 AM
Unknown Object (File)
Thu, Feb 6, 7:34 AM
Unknown Object (File)
Mon, Feb 3, 5:37 AM
Unknown Object (File)
Thu, Jan 30, 10:28 AM
Unknown Object (File)
Tue, Jan 28, 12:31 AM
Unknown Object (File)
Sun, Jan 26, 7:17 AM
Unknown Object (File)
Sun, Jan 26, 2:07 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10010: Implement Subprojects
Commits
Restricted Diffusion Commit
rP16d8e806a0bc: Simplify ProjectQuery handling of viewer membership
Summary

Ref T10010. Currently, we do an unusual JOIN to make testing for viewer membership in projects a little cheaper.

This won't work as-is once we have subprojects, so standardize, simplify, and cover it with more tests for now. (I may be able to get a similar optimization later, but want a correct implementation first.)

Test Plan

This change should create no behavioral differences.

  • Added tests.
  • Ran tests.
  • Viewed projects.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35924.Dec 23 2015, 11:59 AM
epriestley retitled this revision from to Simplify ProjectQuery handling of viewer membership.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10010: Implement Subprojects.
chad accepted this revision.Dec 23 2015, 4:35 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 23 2015, 4:36 PM
Closed by commit rP16d8e806a0bc: Simplify ProjectQuery handling of viewer membership (authored by epriestley, committed by epriestley). · Explain WhyDec 23 2015, 10:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
applications/
project/
__tests__/
editor/
__tests__/
PhabricatorProjectCoreTestCase.php
PhabricatorProjectEditorTestCase.php
95 lines
editor/
__tests__/
query/
113 lines

Diff 35937

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/project/__tests__/PhabricatorProjectCoreTestCase.php

Loading...
View Options

src/applications/project/editor/__tests__/PhabricatorProjectEditorTestCase.php

Loading...
View Options

src/applications/project/query/PhabricatorProjectQuery.php

Loading...
Phabricator · Built by Phacility