Page MenuHomePhabricator

Prepare DestructionEngine to be modularized
ClosedPublic

Authored by epriestley on Dec 20 2015, 3:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 3:07 AM
Unknown Object (File)
Tue, Mar 5, 3:41 PM
Unknown Object (File)
Feb 15 2024, 3:51 AM
Unknown Object (File)
Feb 6 2024, 9:40 AM
Unknown Object (File)
Feb 3 2024, 7:55 AM
Unknown Object (File)
Jan 2 2024, 8:15 AM
Unknown Object (File)
Dec 29 2023, 3:41 AM
Unknown Object (File)
Dec 27 2023, 7:53 AM
Subscribers
None

Details

Summary

Ref T9979. The general shape of "engine" code feels pretty good, and I plan to move indexing to be more in line with other modern engines, with the ultimate goal of supporting subprojects (T10010) and several intermediate goals.

Before moving indexing, clean up Destruction, since some of the new indexes will need destruction hooks and destruction currently has a lot of instanceof stuff that should be easy to fix by applying more modern approaches.

Test Plan
  • Used bin/remove destroy to destory an Almanac device.
  • Verified that properties for the device were destroyed.
  • Viewed module panel in UI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Prepare DestructionEngine to be modularized.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 20 2015, 4:05 PM
This revision was automatically updated to reflect the committed changes.