Page MenuHomePhabricator
Differential D14822

Clean up "HTTP Parameters" view a bit for EditEngine forms
ClosedPublic
Actions

Authored by epriestley on Dec 18 2015, 6:53 PM.
Tags
None
Referenced Files
F15188165: D14822.diff
Fri, Feb 21, 1:02 PM
Unknown Object (File)
Fri, Feb 14, 4:02 AM
Unknown Object (File)
Sun, Feb 9, 12:12 AM
Unknown Object (File)
Sun, Feb 9, 12:12 AM
Unknown Object (File)
Sun, Feb 9, 12:12 AM
Unknown Object (File)
Sun, Feb 9, 12:12 AM
Unknown Object (File)
Sun, Feb 9, 12:12 AM
Unknown Object (File)
Thu, Feb 6, 11:40 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10004: ApplicationEditor Errata
Commits
Restricted Diffusion Commit
rPa1a8b9ba657e: Clean up "HTTP Parameters" view a bit for EditEngine forms
Summary

Ref T10004. This lost a couple of fields when I rearranged how descriptions work. Restore them.

Test Plan
  • Viewed "Using HTTP Parameters".
  • Everything had nice descriptions.
  • No more weird phantom/misleading 'comment' transaction in UI.

Diff Detail

Repository
rP Phabricator
Branch
create3
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:843XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 9654
Build 11564: Run Core Tests
Build 11563: arc lint + arc unit

Event Timeline

chad accepted this revision.Dec 18 2015, 7:35 PM
chad edited edge metadata.

FYI, not getting emailed on these last 4 diffs.

This revision is now accepted and ready to land.Dec 18 2015, 7:35 PM
chad added a comment.Dec 18 2015, 7:35 PM

I couldn't find D14822 in /mail/ either.

chad added a comment.Dec 18 2015, 7:37 PM

(also not in feedypoo)

epriestley added a comment.Dec 18 2015, 7:55 PM

I think the "Create" thing will fix that, the problem is all the transactions were getting hidden so it was just like "well I guess nothing happened" and declines to publish the story or send any mail about it.

epriestley updated this revision to Diff 35836.Dec 18 2015, 8:00 PM
epriestley edited edge metadata.
  • Also piggyback in a minor TYPE_CREATE fix for Differential and other non-EditEngine applications.
Closed by commit rPa1a8b9ba657e: Clean up "HTTP Parameters" view a bit for EditEngine forms (authored by epriestley, committed by epriestley). · Explain WhyDec 18 2015, 8:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
policy/
editor/
7 lines
subscriptions/
engineextension/
1 line
transactions/
editor/
12 lines
view/
6 lines

Diff 35836

View Options

src/applications/policy/editor/PhabricatorPolicyEditEngineExtension.php

Loading...
View Options

src/applications/subscriptions/engineextension/PhabricatorSubscriptionsEditEngineExtension.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
View Options

src/applications/transactions/view/PhabricatorApplicationEditHTTPParameterHelpView.php

Loading...
Phabricator · Built by Phacility