Fix value reading in custom Text and Remarkup fields in EditEngine
ClosedPublic
Actions

Authored by epriestley on Dec 18 2015, 6:47 PM.

Tags

None

Referenced Files

	F13167797: D14821.diff
	Tue, May 7, 7:23 AM

	Unknown Object (File)
	Fri, May 3, 6:06 AM

	Unknown Object (File)
	Thu, Apr 25, 1:01 AM

	Unknown Object (File)
	Tue, Apr 16, 8:18 PM

	Unknown Object (File)
	Sun, Apr 14, 4:26 PM

	Unknown Object (File)
	Thu, Apr 11, 8:45 AM

	Unknown Object (File)
	Wed, Apr 10, 11:57 PM

	Unknown Object (File)
	Mar 31 2024, 10:29 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T10004: ApplicationEditor Errata

Commits

Restricted Diffusion Commit
rP46e690b2fd69: Fix value reading in custom Text and Remarkup fields in EditEngine

Summary

Ref T10004. I missed these previously, so they didn't work quite right. Restore them to glory.

Test Plan

Edited remarkup and text custom fields on an Owners package.

Diff Detail

Repository

rP Phabricator

Branch

create2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9649
Build 11557: Run Core Tests
Build 11556: arc lint + arc unit

Event Timeline

chad accepted this revision.Dec 18 2015, 7:33 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 18 2015, 7:33 PM

Closed by commit rP46e690b2fd69: Fix value reading in custom Text and Remarkup fields in EditEngine (authored by epriestley, committed by epriestley). · Explain WhyDec 18 2015, 7:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

customfield/

standard/

PhabricatorStandardCustomFieldRemarkup.php

4 lines

PhabricatorStandardCustomFieldText.php

4 lines

Diff 35831

View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php