Page MenuHomePhabricator
Differential D14815

Indent multiple items from the same application in Quick Create menu
ClosedPublic
Actions

Authored by epriestley on Dec 17 2015, 10:28 PM.
Tags
None
Referenced Files
F14039017: D14815.diff
Mon, Nov 11, 3:17 AM
F14030693: D14815.id.diff
Sat, Nov 9, 5:29 AM
F14030671: D14815.id.diff
Sat, Nov 9, 5:05 AM
F14030553: D14815.id35818.diff
Sat, Nov 9, 4:16 AM
F14030527: D14815.id35816.diff
Sat, Nov 9, 4:09 AM
F14030516: D14815.id35818.diff
Sat, Nov 9, 4:07 AM
F14030510: D14815.id35816.diff
Sat, Nov 9, 4:05 AM
F14030460: D14815.diff
Sat, Nov 9, 3:39 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10004: ApplicationEditor Errata
Commits
Restricted Diffusion Commit
Restricted Diffusion Commit
rP76a59b0bbf68: Update the Celerity map.
rPa3bdce96806d: Indent multiple items from the same application in Quick Create menu
Summary

Ref T10004. Happy to take another approach here or just not bother, this just struck me as a little ambiguous/confusing.

Test Plan

Before, not necessarily clear that the "Create Task" header only applies to the first few items.

Screen Shot 2015-12-17 at 2.26.41 PM.png (317×222 px, 31 KB)

After, more clear:

Screen Shot 2015-12-17 at 2.26.36 PM.png (344×200 px, 29 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Herald edited edge metadata. · View Herald TranscriptDec 17 2015, 10:28 PM
chad accepted this revision.Dec 17 2015, 11:01 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 17 2015, 11:01 PM
Closed by commit rPa3bdce96806d: Indent multiple items from the same application in Quick Create menu (authored by epriestley, committed by epriestley). · Explain WhyDec 17 2015, 11:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
editengine/
3 lines
view/
phui/
21 lines
webroot/
rsrc/
css/
phui/
5 lines

Diff 35818

View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...
View Options

src/view/phui/PHUIListItemView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-list.css

Loading...
Phabricator · Built by Phacility