Page MenuHomePhabricator

Prevent "Spaces" field from being set to inconsistent values
ClosedPublic

Authored by epriestley on Dec 17 2015, 7:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 18 2025, 12:33 PM
Unknown Object (File)
May 11 2025, 5:13 AM
Unknown Object (File)
May 9 2025, 9:47 PM
Unknown Object (File)
May 6 2025, 10:14 AM
Unknown Object (File)
Apr 11 2025, 10:12 PM
Unknown Object (File)
Apr 8 2025, 4:47 AM
Unknown Object (File)
Apr 7 2025, 5:11 PM
Unknown Object (File)
Apr 5 2025, 6:03 PM
Subscribers
None

Details

Summary

At least for now, the "Space" field is just a subfield of the "Visible To" field, so:

  • it doesn't get any separate settings; and
  • it always uses the "Visible To" settings.
Test Plan
  • Created a form with a hidden view policy field.
  • Created stuff with no "you must pick a space" errors.
  • Created stuff with a normal form.
  • Prefilled "Space" on a noraml form.
  • Verified that trying to prefill "Space" on a form with "Visible To" hidden does nothing.

Diff Detail

Repository
rP Phabricator
Branch
ae9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9625
Build 11522: Run Core Tests
Build 11521: arc lint + arc unit