Page MenuHomePhabricator

Prevent "Spaces" field from being set to inconsistent values
ClosedPublic

Authored by epriestley on Dec 17 2015, 7:02 PM.
Tags
None
Referenced Files
F12181702: D14812.diff
Tue, Sep 12, 11:35 PM
F12153552: D14812.diff
Mon, Sep 4, 12:52 AM
F12151975: D14812.id.diff
Sun, Sep 3, 9:54 AM
F12148690: D14812.id.diff
Sat, Sep 2, 1:36 AM
F12147652: D14812.diff
Fri, Sep 1, 4:56 PM
Unknown Object (File)
Jul 25 2023, 10:23 PM
Unknown Object (File)
Jul 22 2023, 8:23 AM
Unknown Object (File)
Jul 16 2023, 12:50 PM
Subscribers
None

Details

Summary

At least for now, the "Space" field is just a subfield of the "Visible To" field, so:

  • it doesn't get any separate settings; and
  • it always uses the "Visible To" settings.
Test Plan
  • Created a form with a hidden view policy field.
  • Created stuff with no "you must pick a space" errors.
  • Created stuff with a normal form.
  • Prefilled "Space" on a noraml form.
  • Verified that trying to prefill "Space" on a form with "Visible To" hidden does nothing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable