Page MenuHomePhabricator

Prevent "Spaces" field from being set to inconsistent values
ClosedPublic

Authored by epriestley on Dec 17 2015, 7:02 PM.
Tags
None
Referenced Files
F18767640: D14812.id35809.diff
Tue, Oct 7, 11:33 PM
F18767628: D14812.id35808.diff
Tue, Oct 7, 11:30 PM
F18766754: D14812.diff
Tue, Oct 7, 6:21 PM
F18764495: D14812.id.diff
Tue, Oct 7, 6:22 AM
F18712982: D14812.id.diff
Mon, Sep 29, 5:35 AM
F18671277: D14812.diff
Thu, Sep 25, 3:19 AM
F18627672: D14812.id.diff
Sep 16 2025, 4:29 AM
F18623868: D14812.diff
Sep 15 2025, 5:54 PM
Subscribers
None

Details

Summary

At least for now, the "Space" field is just a subfield of the "Visible To" field, so:

  • it doesn't get any separate settings; and
  • it always uses the "Visible To" settings.
Test Plan
  • Created a form with a hidden view policy field.
  • Created stuff with no "you must pick a space" errors.
  • Created stuff with a normal form.
  • Prefilled "Space" on a noraml form.
  • Verified that trying to prefill "Space" on a form with "Visible To" hidden does nothing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable