Page MenuHomePhabricator

Prevent "Spaces" field from being set to inconsistent values
ClosedPublic

Authored by epriestley on Dec 17 2015, 7:02 PM.
Tags
None
Referenced Files
F15444693: D14812.diff
Thu, Mar 27, 10:45 AM
F15436915: D14812.id35808.diff
Tue, Mar 25, 4:46 PM
F15435044: D14812.diff
Tue, Mar 25, 6:37 AM
F15385657: D14812.id.diff
Fri, Mar 14, 11:04 PM
Unknown Object (File)
Feb 25 2025, 12:46 PM
Unknown Object (File)
Feb 11 2025, 2:48 PM
Unknown Object (File)
Feb 9 2025, 12:11 AM
Unknown Object (File)
Feb 9 2025, 12:11 AM
Subscribers
None

Details

Summary

At least for now, the "Space" field is just a subfield of the "Visible To" field, so:

  • it doesn't get any separate settings; and
  • it always uses the "Visible To" settings.
Test Plan
  • Created a form with a hidden view policy field.
  • Created stuff with no "you must pick a space" errors.
  • Created stuff with a normal form.
  • Prefilled "Space" on a noraml form.
  • Verified that trying to prefill "Space" on a form with "Visible To" hidden does nothing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable