Page MenuHomePhabricator

Prevent "Spaces" field from being set to inconsistent values
ClosedPublic

Authored by epriestley on Dec 17 2015, 7:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 9:00 PM
Unknown Object (File)
Sun, Dec 15, 6:16 PM
Unknown Object (File)
Mon, Dec 9, 12:13 PM
Unknown Object (File)
Thu, Dec 5, 11:13 AM
Unknown Object (File)
Wed, Dec 4, 8:59 PM
Unknown Object (File)
Wed, Dec 4, 7:37 PM
Unknown Object (File)
Sun, Dec 1, 6:43 AM
Unknown Object (File)
Thu, Nov 28, 2:21 PM
Subscribers
None

Details

Summary

At least for now, the "Space" field is just a subfield of the "Visible To" field, so:

  • it doesn't get any separate settings; and
  • it always uses the "Visible To" settings.
Test Plan
  • Created a form with a hidden view policy field.
  • Created stuff with no "you must pick a space" errors.
  • Created stuff with a normal form.
  • Prefilled "Space" on a noraml form.
  • Verified that trying to prefill "Space" on a form with "Visible To" hidden does nothing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable