Page MenuHomePhabricator

Prevent "Spaces" field from being set to inconsistent values
ClosedPublic

Authored by epriestley on Dec 17 2015, 7:02 PM.
Tags
None
Referenced Files
F14064972: D14812.diff
Tue, Nov 19, 2:26 AM
F13980858: D14812.diff
Oct 19 2024, 12:56 PM
Unknown Object (File)
Sep 26 2024, 8:30 AM
Unknown Object (File)
Sep 6 2024, 4:32 PM
Unknown Object (File)
Aug 28 2024, 10:34 PM
Unknown Object (File)
Aug 28 2024, 10:34 PM
Unknown Object (File)
Aug 28 2024, 10:33 PM
Unknown Object (File)
Aug 28 2024, 10:21 PM
Subscribers
None

Details

Summary

At least for now, the "Space" field is just a subfield of the "Visible To" field, so:

  • it doesn't get any separate settings; and
  • it always uses the "Visible To" settings.
Test Plan
  • Created a form with a hidden view policy field.
  • Created stuff with no "you must pick a space" errors.
  • Created stuff with a normal form.
  • Prefilled "Space" on a noraml form.
  • Verified that trying to prefill "Space" on a form with "Visible To" hidden does nothing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable