Paths

Table of Contentst

Differential D14805

Remove all setObjectURI() from ActionListViews
ClosedPublic
Actions

Authored by epriestley on Dec 17 2015, 2:37 PM.

Tags

None

Referenced Files

	F13103158: D14805.diff
	Sat, Apr 27, 9:18 AM

	Unknown Object (File)
	Wed, Apr 24, 10:22 AM

	Unknown Object (File)
	Wed, Apr 17, 11:20 PM

	Unknown Object (File)
	Sun, Apr 14, 4:25 PM

	Unknown Object (File)
	Sat, Apr 13, 5:53 PM

	Unknown Object (File)
	Thu, Apr 11, 12:48 PM

	Unknown Object (File)
	Wed, Apr 10, 7:45 AM

	Unknown Object (File)
	Sat, Apr 6, 9:23 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T10004: ApplicationEditor Errata

Commits

Restricted Diffusion Commit
rP2868a69f658c: Remove all setObjectURI() from ActionListViews

Summary

Ref T10004. After D14804, we get this behavior by default and no longer need to set it explicitly.

(If some endpoint did eventually need to set it explicitly, it could just change what it passes to setHref(), but I believe we currently have no such endpoints and do not foresee ever having any.)

Test Plan

As a logged out user, clicked various links in Differential, Maniphest, Files, etc., always got redirected to a sensible place after login.
Grepped for setObjectURI(), getObjectURI() (there are a few remaining callsites, but to a different method with the same name in Doorkeeper).

Diff Detail

Repository

Branch

ae2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9611
Build 11502: Run Core Tests
Build 11501: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35794.Dec 17 2015, 2:37 PM

epriestley retitled this revision from to Remove all setObjectURI() from ActionListViews.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10004: ApplicationEditor Errata.

Herald added a subscriber: hach-que. · View Herald TranscriptDec 17 2015, 2:37 PM

epriestley mentioned this in T10004: ApplicationEditor Errata.Dec 17 2015, 3:05 PM

itsawesome

This revision is now accepted and ready to land.Dec 17 2015, 3:31 PM

Closed by commit rP2868a69f658c: Remove all setObjectURI() from ActionListViews (authored by epriestley, committed by epriestley). · Explain WhyDec 17 2015, 4:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

controller/

PhabricatorCalendarEventViewController.php

1 line

dashboard/

controller/

PhabricatorDashboardManageController.php

1 line

PhabricatorDashboardPanelViewController.php

1 line

differential/

view/

DifferentialRevisionDetailView.php

3 lines

diffusion/

controller/

DiffusionCommitController.php

3 lines

DiffusionRepositoryController.php

4 lines

DiffusionRepositoryEditMainController.php

13 lines

diviner/

controller/

DivinerBookController.php

3 lines

drydock/

controller/

DrydockAuthorizationViewController.php

1 line

DrydockBlueprintViewController.php

1 line

DrydockLeaseViewController.php

1 line

DrydockRepositoryOperationViewController.php

1 line

DrydockResourceViewController.php

1 line

files/

controller/

PhabricatorFileInfoController.php

1 line

harbormaster/

controller/

HarbormasterBuildViewController.php

3 lines

HarbormasterBuildableViewController.php

3 lines

HarbormasterPlanViewController.php

3 lines

herald/

controller/

HeraldRuleViewController.php

3 lines

legalpad/

controller/

LegalpadDocumentManageController.php

1 line

macro/

controller/

PhabricatorMacroViewController.php

1 line

maniphest/

controller/

ManiphestTaskDetailController.php

3 lines

meta/

controller/

PhabricatorApplicationDetailViewController.php

3 lines

nuance/

controller/

NuanceQueueViewController.php

1 line

NuanceSourceViewController.php

1 line

passphrase/

controller/

PassphraseCredentialViewController.php

1 line

paste/

controller/

PhabricatorPasteViewController.php

3 lines

people/

controller/

PhabricatorPeopleProfileController.php

1 line

phame/

controller/

blog/

PhameBlogManageController.php

1 line

PhameBlogViewController.php

1 line

post/

PhamePostViewController.php

1 line

phlux/

controller/

PhluxViewController.php

1 line

pholio/

controller/

PholioMockViewController.php

1 line

phortune/

controller/

PhortuneAccountViewController.php

1 line

PhortuneProductViewController.php

3 lines

PhortuneSubscriptionViewController.php

3 lines

phragment/

controller/

PhragmentController.php

3 lines

PhragmentSnapshotViewController.php

3 lines

PhragmentVersionController.php

3 lines

phriction/

controller/

PhrictionDocumentController.php

1 line

phurl/

controller/

PhabricatorPhurlURLViewController.php

1 line

ponder/

controller/

PonderQuestionViewController.php

3 lines

view/

PonderAnswerView.php

3 lines

project/

controller/

PhabricatorProjectColumnDetailController.php

1 line

PhabricatorProjectProfileController.php

3 lines

releeph/

controller/

branch/

ReleephBranchViewController.php

3 lines

product/

ReleephProductViewController.php

3 lines

spaces/

controller/

PhabricatorSpacesViewController.php

3 lines

view/

layout/

PhabricatorActionListView.php

7 lines

PhabricatorActionView.php

22 lines

Diff 35794

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Loading...

src/applications/dashboard/controller/PhabricatorDashboardManageController.php

Loading...

src/applications/dashboard/controller/PhabricatorDashboardPanelViewController.php

Loading...

src/applications/differential/view/DifferentialRevisionDetailView.php

Loading...

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...

src/applications/diffusion/controller/DiffusionRepositoryController.php

Loading...

src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php

Loading...

src/applications/diviner/controller/DivinerBookController.php

Loading...

src/applications/drydock/controller/DrydockAuthorizationViewController.php

Loading...

src/applications/drydock/controller/DrydockBlueprintViewController.php

Loading...

src/applications/drydock/controller/DrydockLeaseViewController.php

Loading...

src/applications/drydock/controller/DrydockRepositoryOperationViewController.php

Loading...

src/applications/drydock/controller/DrydockResourceViewController.php

Loading...

src/applications/files/controller/PhabricatorFileInfoController.php

Loading...

src/applications/harbormaster/controller/HarbormasterBuildViewController.php

Loading...

src/applications/harbormaster/controller/HarbormasterBuildableViewController.php

Loading...

src/applications/harbormaster/controller/HarbormasterPlanViewController.php

Loading...

src/applications/herald/controller/HeraldRuleViewController.php

Loading...

src/applications/legalpad/controller/LegalpadDocumentManageController.php

Loading...

src/applications/macro/controller/PhabricatorMacroViewController.php

Loading...

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...

src/applications/meta/controller/PhabricatorApplicationDetailViewController.php

Loading...

src/applications/nuance/controller/NuanceQueueViewController.php

Loading...

src/applications/nuance/controller/NuanceSourceViewController.php

Loading...

src/applications/passphrase/controller/PassphraseCredentialViewController.php

Loading...

src/applications/paste/controller/PhabricatorPasteViewController.php

Loading...

src/applications/people/controller/PhabricatorPeopleProfileController.php

Loading...

src/applications/phame/controller/blog/PhameBlogManageController.php

Loading...

src/applications/phame/controller/blog/PhameBlogViewController.php

Loading...

src/applications/phame/controller/post/PhamePostViewController.php

Loading...

src/applications/phlux/controller/PhluxViewController.php

Loading...

src/applications/pholio/controller/PholioMockViewController.php

Loading...

src/applications/phortune/controller/PhortuneAccountViewController.php

Loading...

src/applications/phortune/controller/PhortuneProductViewController.php

Loading...

src/applications/phortune/controller/PhortuneSubscriptionViewController.php

Loading...

src/applications/phragment/controller/PhragmentController.php

Loading...

src/applications/phragment/controller/PhragmentSnapshotViewController.php

Loading...

src/applications/phragment/controller/PhragmentVersionController.php

Loading...

src/applications/phriction/controller/PhrictionDocumentController.php

Loading...

src/applications/phurl/controller/PhabricatorPhurlURLViewController.php

Loading...

src/applications/ponder/controller/PonderQuestionViewController.php

Loading...

src/applications/ponder/view/PonderAnswerView.php

Loading...

src/applications/project/controller/PhabricatorProjectColumnDetailController.php

Loading...

src/applications/project/controller/PhabricatorProjectProfileController.php

Loading...

src/applications/releeph/controller/branch/ReleephBranchViewController.php

Loading...

src/applications/releeph/controller/product/ReleephProductViewController.php

Loading...

src/applications/spaces/controller/PhabricatorSpacesViewController.php

Loading...

src/view/layout/PhabricatorActionListView.php

Loading...

src/view/layout/PhabricatorActionView.php

Loading...