Page MenuHomePhabricator

Provide a "PHUIFormIconSetControl"
ClosedPublic

Authored by epriestley on Dec 16 2015, 4:34 PM.
Tags
None
Referenced Files
F19837837: D14799.id35780.diff
Mar 11 2026, 3:43 PM
F19669367: D14799.id35780.diff
Feb 7 2026, 8:58 PM
F19669365: D14799.id35780.diff
Feb 7 2026, 8:58 PM
F19554483: D14799.id35783.diff
Jan 29 2026, 10:29 PM
F19554482: D14799.id.diff
Jan 29 2026, 10:29 PM
F19177110: D14799.id35783.diff
Dec 16 2025, 12:17 AM
F18907584: D14799.id35783.diff
Nov 9 2025, 12:07 AM
F18907583: D14799.id.diff
Nov 9 2025, 12:07 AM
Subscribers
None

Details

Summary

Ref T9992. This is a step on the path to getting EditEngine working in Badges, Projects and Calendar.

This doesn't add a new EditField for icons yet, just standardizes the old stuff. New stuff is more general and I saved 150 lines of code.

I put the endpoint in Files because the similar "choose a profile picture" endpoint will definitely go there, and this endpoint might eventually feature, like, "draw your own icon~~" or something.

Test Plan
  • Created events, projects and badges with custom icons.
  • Edited events, projects and badges, changing their icons.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Provide a "PHUIFormIconSetControl".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2015, 4:37 PM
This revision was automatically updated to reflect the committed changes.