Page MenuHomePhabricator

Provide a "PHUIFormIconSetControl"
ClosedPublic

Authored by epriestley on Dec 16 2015, 4:34 PM.
Tags
None
Referenced Files
F14017501: D14799.diff
Mon, Nov 4, 6:05 PM
F14016288: D14799.id.diff
Mon, Nov 4, 7:41 AM
F13992103: D14799.id.diff
Tue, Oct 22, 2:23 PM
F13990287: D14799.id35780.diff
Tue, Oct 22, 2:26 AM
F13990274: D14799.diff
Tue, Oct 22, 2:20 AM
F13988893: D14799.id35783.diff
Mon, Oct 21, 4:33 PM
F13987888: D14799.id.diff
Mon, Oct 21, 12:02 PM
F13987801: D14799.diff
Mon, Oct 21, 11:22 AM
Subscribers
None

Details

Summary

Ref T9992. This is a step on the path to getting EditEngine working in Badges, Projects and Calendar.

This doesn't add a new EditField for icons yet, just standardizes the old stuff. New stuff is more general and I saved 150 lines of code.

I put the endpoint in Files because the similar "choose a profile picture" endpoint will definitely go there, and this endpoint might eventually feature, like, "draw your own icon~~" or something.

Test Plan
  • Created events, projects and badges with custom icons.
  • Edited events, projects and badges, changing their icons.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Provide a "PHUIFormIconSetControl".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2015, 4:37 PM
This revision was automatically updated to reflect the committed changes.