Page MenuHomePhabricator

Fix overzealous subscribing in EditEngine
ClosedPublic

Authored by epriestley on Dec 16 2015, 12:12 AM.
Tags
None
Referenced Files
F13123643: D14795.diff
Tue, Apr 30, 11:35 AM
Unknown Object (File)
Mon, Apr 29, 3:45 PM
Unknown Object (File)
Sun, Apr 28, 9:00 AM
Unknown Object (File)
Wed, Apr 24, 11:43 PM
Unknown Object (File)
Sat, Apr 20, 7:20 AM
Unknown Object (File)
Fri, Apr 19, 3:56 PM
Unknown Object (File)
Wed, Apr 17, 5:33 PM
Unknown Object (File)
Thu, Apr 11, 8:00 AM
Subscribers

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rP1d72c97fc9f6: Fix overzealous subscribing in EditEngine
Summary

See T9905#148799. The CommentEditField generated empty comment transactions; these are dropped later, but before they are dropped they would trigger implicit CCs.

The implicit CC rule should probably be narrower, but we shouldn't be generating these transactions in the first place.

Test Plan

No longer implicitly CC'd on a task when doing something minor like changing projects.

Diff Detail

Repository
rP Phabricator
Branch
ee6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9592
Build 11472: Run Core Tests
Build 11471: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix overzealous subscribing in EditEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a subscriber: avivey.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 16 2015, 12:15 AM
This revision was automatically updated to reflect the committed changes.