Differential D14787

Fix an issue with the Spaces EditField not reading values properly
ClosedPublic
Actions

Authored by epriestley on Dec 15 2015, 2:14 PM.

Details

Reviewers

chad

Maniphest Tasks

T9988: Cant shift Task to another Space

Commits

Restricted Diffusion Commit
rPab748e522aa3: Fix an issue with the Spaces EditField not reading values properly

Summary

Fixes T9988. This logic got inverted by accident at some point.

Test Plan

Edited a task, shifting spaces.
Created a task in default space.
Created a task in custom space.

Diff Detail

Repository

rP Phabricator

Branch

ee1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9575
Build 11446: Run Core Tests
Build 11445: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35757.Dec 15 2015, 2:14 PM

epriestley retitled this revision from to Fix an issue with the Spaces EditField not reading values properly.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9988: Cant shift Task to another Space.

chad accepted this revision.Dec 15 2015, 2:36 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 15 2015, 2:36 PM

Closed by commit rPab748e522aa3: Fix an issue with the Spaces EditField not reading values properly (authored by epriestley, committed by epriestley). · Explain WhyDec 15 2015, 2:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

policy/

editor/

PhabricatorPolicyEditEngineExtension.php

2 lines

Diff 35757

View Options

src/applications/policy/editor/PhabricatorPolicyEditEngineExtension.php

Fix an issue with the Spaces EditField not reading values properlyClosedPublicActions