Fix an issue with the Spaces EditField not reading values properly
ClosedPublic
Actions

Authored by epriestley on Dec 15 2015, 2:14 PM.

Tags

None

Referenced Files

	F15479816: D14787.id.diff
	Tue, Apr 8, 9:41 AM

	F15477452: D14787.diff
	Mon, Apr 7, 2:47 PM

	F15421373: D14787.id35759.diff
	Fri, Mar 21, 11:04 PM

	F15411981: D14787.id35759.diff
	Wed, Mar 19, 10:38 AM

	F15389729: D14787.id35757.diff
	Sat, Mar 15, 5:36 AM

	F15368091: D14787.id35759.diff
	Tue, Mar 11, 11:48 PM

	F15331501: D14787.id35757.diff
	Mar 7 2025, 10:40 AM

	Unknown Object (File)
	Feb 19 2025, 5:35 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T9988: Cant shift Task to another Space

Commits

Restricted Diffusion Commit
rPab748e522aa3: Fix an issue with the Spaces EditField not reading values properly

Summary

Fixes T9988. This logic got inverted by accident at some point.

Test Plan

Edited a task, shifting spaces.
Created a task in default space.
Created a task in custom space.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35757.Dec 15 2015, 2:14 PM

epriestley retitled this revision from to Fix an issue with the Spaces EditField not reading values properly.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9988: Cant shift Task to another Space.

chad accepted this revision.Dec 15 2015, 2:36 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 15 2015, 2:36 PM

Closed by commit rPab748e522aa3: Fix an issue with the Spaces EditField not reading values properly (authored by epriestley, committed by epriestley). · Explain WhyDec 15 2015, 2:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

policy/

editor/

PhabricatorPolicyEditEngineExtension.php

2 lines

Diff 35759

View Options

src/applications/policy/editor/PhabricatorPolicyEditEngineExtension.php

Fix an issue with the Spaces EditField not reading values properlyClosedPublicActions