Differential D14783

Clean up an issue with meta-editing of edit engines
ClosedPublic
Actions

Authored by epriestley on Dec 14 2015, 9:32 PM.

Details

Reviewers

chad

Maniphest Tasks

T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter

Commits

Restricted Diffusion Commit
rP81ae9f8fb6a2: Clean up an issue with meta-editing of edit engines

Summary

Ref T9908. These meta-edit-engines are used to generate the main editengine UIs, but they're also editable.

Fix an exception when trying to edit the meta editengine.

Test Plan

Edited editengineconfiguration editengine.

Diff Detail

Repository

rP Phabricator

Branch

clog6

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9562
Build 11429: Run Core Tests
Build 11428: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35744.Dec 14 2015, 9:32 PM

epriestley retitled this revision from to Clean up an issue with meta-editing of edit engines.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

epriestley mentioned this in T9983: Maniphest "No Create Permission" as Admin.Dec 14 2015, 9:49 PM

chad accepted this revision.Dec 14 2015, 9:53 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 14 2015, 9:53 PM

Closed by commit rP81ae9f8fb6a2: Clean up an issue with meta-editing of edit engines (authored by epriestley, committed by epriestley). · Explain WhyDec 14 2015, 11:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

controller/

PhabricatorEditEngineController.php

7 lines

editor/

PhabricatorEditEngineConfigurationEditEngine.php

3 lines

Diff 35744

View Options

src/applications/transactions/controller/PhabricatorEditEngineController.php