Add by-caller lookup to call logs, plus viewer calls


Add by-caller lookup to call logs, plus viewer calls

Ref T9980. By default, show the viewer their calls.

Make it easy to find their own deprecated calls.

I don't like the word "My" but couldn't come up with anything better that didn't feel like a big loss of clarity.

The permissions on this log are also a little weird: non-admins can see everyone else's calls.

I think we should eventually lock that down, but plan to keep it this way for now:

First, a lot of your calls end up with no caller set right now, because we don't set the caller early enough in the process so a lot differnet types of errors can leave us with no user on the log. Fixing that isn't trivial, and users may reasonably want to access to these "no caller" logs to check for errors or debug stuff.

Second, none of it is really that sensitive?

Third, it's reasonable for users to want to look at bots?

I'd plan to maybe do this eventually:

  • Make the caller get populated more often after auth code is simplified.
  • Only let users look at their calls and maybe bot calls and anonymous calls.
  • Let admins look at everything.

But for now everyone can see everything.

Test Plan:

Screen Shot 2015-12-14 at 1.24.04 PM.png (997×1 px, 137 KB)

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9980

Differential Revision: https://secure.phabricator.com/D14782