Page MenuHomePhabricator

Add by-caller lookup to call logs, plus viewer calls
ClosedPublic

Authored by epriestley on Dec 14 2015, 9:24 PM.
Tags
None
Referenced Files
F14029056: D14782.id35751.diff
Fri, Nov 8, 7:07 PM
F14026200: D14782.diff
Fri, Nov 8, 12:01 AM
F14022119: D14782.id35751.diff
Wed, Nov 6, 3:22 PM
F14013558: D14782.id35751.diff
Sat, Nov 2, 7:43 AM
F14001811: D14782.id35743.diff
Fri, Oct 25, 12:12 PM
F13965877: D14782.id.diff
Wed, Oct 16, 4:49 AM
Unknown Object (File)
Oct 2 2024, 7:51 AM
Unknown Object (File)
Sep 20 2024, 5:55 AM
Subscribers
None

Details

Summary

Ref T9980. By default, show the viewer their calls.

Make it easy to find their own deprecated calls.

I don't like the word "My" but couldn't come up with anything better that didn't feel like a big loss of clarity.

The permissions on this log are also a little weird: non-admins can see everyone else's calls.

I think we should eventually lock that down, but plan to keep it this way for now:

First, a lot of your calls end up with no caller set right now, because we don't set the caller early enough in the process so a lot differnet types of errors can leave us with no user on the log. Fixing that isn't trivial, and users may reasonably want to access to these "no caller" logs to check for errors or debug stuff.

Second, none of it is really that sensitive?

Third, it's reasonable for users to want to look at bots?

I'd plan to maybe do this eventually:

  • Make the caller get populated more often after auth code is simplified.
  • Only let users look at their calls and maybe bot calls and anonymous calls.
  • Let admins look at everything.

But for now everyone can see everything.

Test Plan

Screen Shot 2015-12-14 at 1.24.04 PM.png (997×1 px, 137 KB)

Diff Detail

Repository
rP Phabricator
Branch
clog5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9561
Build 11427: Run Core Tests
Build 11426: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Add by-caller lookup to call logs, plus viewer calls.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 14 2015, 9:56 PM
This revision was automatically updated to reflect the committed changes.