Convert Badges to use EditEngine
ClosedPublic
Actions

Authored by chad on Dec 14 2015, 4:14 AM.

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP45ccc930ec4a: Convert Badges to use EditEngine

Summary

Moves Badges over to EditEngine

Test Plan

Create a new Badge, Edit a Badge

Diff Detail

Repository

rP Phabricator

Branch

badges-edit (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9530
Build 11380: Run Core Tests
Build 11379: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 35712.Dec 14 2015, 4:14 AM

chad retitled this revision from to Convert Badges to use EditEngine.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptDec 14 2015, 4:14 AM

Yeah, let me create some kind of "IconDatasource" thing that works like Tokenizers do, then we can swap them out as we bring EditEngine in. I'll file something to get that built. The rest of this looks good.

yeah, it's like deceptively simple. though looks like I need to add an archive thingy for conduit.

Either:

Take a crack at implementing the new EditField for icons; or
if that doesn't go well, stick a text field in there for now or just TODO it and I'll counter-diff you with the IconSetEditField?

This revision now requires changes to proceed.Dec 16 2015, 4:44 PM