Paths

Table of Contentst

Differential D14717

Drop "-pro" suffix and "editpro" URIs for EditEngine in Maniphest
ClosedPublic
Actions

Authored by epriestley on Dec 9 2015, 12:57 AM.

Details

Reviewers

chad

Maniphest Tasks

T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter

Commits

Restricted Diffusion Commit
rPb3fbf883e0d4: Drop "-pro" suffix and "editpro" URIs for EditEngine in Maniphest

Summary

Ref T9908. Move all the "pro" stuff into the old locations.

Test Plan

Created/edited tasks, looked at URIs, saw non-pro ones. Grepped for editpro.

Diff Detail

Repository

rP Phabricator

Branch

ex44

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9408
Build 11197: Run Core Tests
Build 11196: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35590.Dec 9 2015, 12:57 AM

epriestley retitled this revision from to Drop "-pro" suffix and "editpro" URIs for EditEngine in Maniphest.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

chad accepted this revision.Dec 9 2015, 1:50 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 9 2015, 1:50 AM

Closed by commit rPb3fbf883e0d4: Drop "-pro" suffix and "editpro" URIs for EditEngine in Maniphest (authored by epriestley, committed by epriestley). · Explain WhyDec 9 2015, 1:57 AM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rP7d0aaf5add72: Fix the Maniphest edit form route.Dec 9 2015, 10:05 AM

epriestley mentioned this in rP2677380d0c94: Also fix the Maniphest internal EditEngine route.Dec 9 2015, 10:14 AM

epriestley mentioned this in Q244: help! click "edit task" or "create subtask",shows 404 (Answer 280).Dec 10 2015, 2:40 PM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

applications/

config/

controller/

PhabricatorConfigWelcomeController.php

2 lines

maniphest/

application/

PhabricatorManiphestApplication.php

4 lines

controller/

ManiphestTaskDetailController.php

6 lines

	ManiphestTaskEditController.php
	ManiphestTaskEditProController.php

2 lines

ManiphestTaskEditProController.php

editor/

ManiphestEditEngine.php

5 lines

view/

ManiphestTaskListView.php

2 lines

project/

controller/

PhabricatorProjectBoardViewController.php

4 lines

view/

ProjectBoardTaskCard.php

2 lines

Diff 35590

View Options

src/__phutil_library_map__.php

View Options

src/applications/config/controller/PhabricatorConfigWelcomeController.php

View Options

src/applications/maniphest/application/PhabricatorManiphestApplication.php

View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

View Options

src/applications/maniphest/controller/ManiphestTaskEditController.php

View Options

src/applications/maniphest/controller/ManiphestTaskEditProController.php

View Options

src/applications/maniphest/editor/ManiphestEditEngine.php

View Options

src/applications/maniphest/view/ManiphestTaskListView.php

View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

View Options

src/applications/project/view/ProjectBoardTaskCard.php

Drop "-pro" suffix and "editpro" URIs for EditEngine in ManiphestClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 35590

src/__phutil_library_map__.php

src/applications/config/controller/PhabricatorConfigWelcomeController.php

src/applications/maniphest/application/PhabricatorManiphestApplication.php

src/applications/maniphest/controller/ManiphestTaskDetailController.php

src/applications/maniphest/controller/ManiphestTaskEditController.php

src/applications/maniphest/controller/ManiphestTaskEditProController.php

src/applications/maniphest/editor/ManiphestEditEngine.php

src/applications/maniphest/view/ManiphestTaskListView.php

src/applications/project/controller/PhabricatorProjectBoardViewController.php

src/applications/project/view/ProjectBoardTaskCard.php

Drop "-pro" suffix and "editpro" URIs for EditEngine in Maniphest
ClosedPublic
Actions

Revision Contents
Changeset List