Paths

Table of Contentst

Support "template objects" generically in EditEngine
ClosedPublic
Actions

Authored by epriestley on Dec 7 2015, 9:40 PM.

Details

Reviewers

Maniphest Tasks

T5622: "copy" attribute for custom fields is not working, at least for text fields
T9132: Build an ApplicationEditor abstraction
T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter

Commits

Restricted Diffusion Commit
rP468f785845ce: Support "template objects" generically in EditEngine

Summary

Ref T9132. Ref T9908. Fixes T5622. This allows you to copy some fields (projects, subscribers, custom fields, some per-application) from another object when creating a new object by passing the ?template=xyz parameter.

Extend "copy" support to work with all custom fields.

Test Plan

Created new pastes, packages, tasks using ?template=...
Viewed new template docs page.

Diff Detail

Repository

rP Phabricator

Branch

ex17

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9366
Build 11134: Run Core Tests
Build 11133: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35549.Dec 7 2015, 9:40 PM

epriestley retitled this revision from to Support "template objects" generically in EditEngine.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter, T9132: Build an ApplicationEditor abstraction, T5622: "copy" attribute for custom fields is not working, at least for text fields.

epriestley mentioned this in T5622: "copy" attribute for custom fields is not working, at least for text fields.Dec 7 2015, 9:40 PM

chad accepted this revision.Dec 7 2015, 9:41 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 7 2015, 9:41 PM

Closed by commit rP468f785845ce: Support "template objects" generically in EditEngine (authored by epriestley, committed by epriestley). · Explain WhyDec 7 2015, 9:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

editor/

ManiphestEditEngine.php

3 lines

owners/

editor/

PhabricatorOwnersPackageEditEngine.php

2 lines

paste/

editor/

PhabricatorPasteEditEngine.php

1 line

policy/

editor/

PhabricatorPolicyEditEngineExtension.php

2 lines

project/

editor/

PhabricatorProjectsEditEngineExtension.php

1 line

subscriptions/

editor/

PhabricatorSubscriptionsEditEngineExtension.php

1 line

transactions/

editengine/

PhabricatorEditEngine.php

55 lines

editfield/

PhabricatorEditField.php

19 lines

storage/

PhabricatorEditEngineConfiguration.php

5 lines

view/

PhabricatorApplicationEditHTTPParameterHelpView.php

55 lines

docs/

user/

configuration/

custom_fields.diviner

11 lines

infrastructure/

customfield/

editor/

PhabricatorCustomFieldEditEngineExtension.php

2 lines

standard/

PhabricatorStandardCustomField.php

16 lines

Diff 35549

View Options

src/applications/maniphest/editor/ManiphestEditEngine.php

View Options

src/applications/owners/editor/PhabricatorOwnersPackageEditEngine.php

View Options

src/applications/paste/editor/PhabricatorPasteEditEngine.php

View Options

src/applications/policy/editor/PhabricatorPolicyEditEngineExtension.php

View Options

src/applications/project/editor/PhabricatorProjectsEditEngineExtension.php

View Options

src/applications/subscriptions/editor/PhabricatorSubscriptionsEditEngineExtension.php

View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

View Options

src/applications/transactions/editfield/PhabricatorEditField.php

View Options

src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php

View Options

src/applications/transactions/view/PhabricatorApplicationEditHTTPParameterHelpView.php

View Options

src/docs/user/configuration/custom_fields.diviner

View Options

src/infrastructure/customfield/editor/PhabricatorCustomFieldEditEngineExtension.php

View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php

Support "template objects" generically in EditEngineClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 35549

src/applications/maniphest/editor/ManiphestEditEngine.php

src/applications/owners/editor/PhabricatorOwnersPackageEditEngine.php

src/applications/paste/editor/PhabricatorPasteEditEngine.php

src/applications/policy/editor/PhabricatorPolicyEditEngineExtension.php

src/applications/project/editor/PhabricatorProjectsEditEngineExtension.php

src/applications/subscriptions/editor/PhabricatorSubscriptionsEditEngineExtension.php

src/applications/transactions/editengine/PhabricatorEditEngine.php

src/applications/transactions/editfield/PhabricatorEditField.php

src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php

src/applications/transactions/view/PhabricatorApplicationEditHTTPParameterHelpView.php

src/docs/user/configuration/custom_fields.diviner

src/infrastructure/customfield/editor/PhabricatorCustomFieldEditEngineExtension.php

src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php

Support "template objects" generically in EditEngine
ClosedPublic
Actions

Revision Contents
Changeset List