Differential D14697

Show node IDs in XHPAST tree view
ClosedPublic
Actions

Authored by joshuaspence on Dec 7 2015, 7:31 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP15550b558224: Show node IDs in XHPAST tree view

Summary

Currently we do not show node IDs in this view, but do show token IDs in the stream view. Given that this view facilitates testing various XHPAST functionality, it would be useful to add this information.

Test Plan

Saw node IDs in XHPAST.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9361
Build 11125: Run Core Tests
Build 11124: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 35544.Dec 7 2015, 7:31 PM

joshuaspence retitled this revision from to Show node IDs in XHPAST tree view.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 7 2015, 7:31 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Dec 22 2015, 1:34 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Dec 22 2015, 1:34 PM

Closed by commit rP15550b558224: Show node IDs in XHPAST tree view (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 22 2015, 9:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phpast/

controller/

PhabricatorXHPASTViewStreamController.php

2 lines

PhabricatorXHPASTViewTreeController.php

2 lines

Diff 35544

View Options

src/applications/phpast/controller/PhabricatorXHPASTViewStreamController.php