Page MenuHomePhabricator
Differential D14685

Add "Is merge commit?" to commit fields in Herald
ClosedPublic
Actions

Authored by epriestley on Dec 5 2015, 8:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 5:18 PM
Unknown Object (File)
Fri, Dec 20, 4:08 PM
Unknown Object (File)
Sun, Dec 8, 11:31 AM
Unknown Object (File)
Fri, Dec 6, 2:22 AM
Unknown Object (File)
Wed, Dec 4, 3:37 AM
Unknown Object (File)
Sun, Dec 1, 10:08 AM
Unknown Object (File)
Sun, Dec 1, 10:08 AM
Unknown Object (File)
Sun, Dec 1, 7:33 AM
View All Files
Subscribers
avivey
Tokens
"Like" token, awarded by avivey.

Details

Reviewers
avivey
chad
Maniphest Tasks
T5788: Support "Commit is a merge" in Herald "Commit" (post-commit) rules
Commits
Restricted Diffusion Commit
rP2353121dee77: Add "Is merge commit?" to commit fields in Herald
Summary

Fixes T5788. We already have this as a pre-commit field, add it as a post-commit field too.

Test Plan

Ran this rule on a merge commit. Also ran it on a non-merge commit. Both got the correct value.

Diff Detail

Repository
rP Phabricator
Branch
ex8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9333
Build 11084: Run Core Tests
Build 11083: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35516.Dec 5 2015, 8:58 PM
epriestley retitled this revision from to Add "Is merge commit?" to commit actions in Herald.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T5788: Support "Commit is a merge" in Herald "Commit" (post-commit) rules.
avivey awarded a token.Dec 5 2015, 9:03 PM
avivey accepted this revision.Dec 5 2015, 9:07 PM
avivey added a reviewer: avivey.
avivey added a subscriber: avivey.

The title should probably be "...rule in herald"?

This revision is now accepted and ready to land.Dec 5 2015, 9:07 PM
epriestley mentioned this in T6763: Allow herald rules to filter on branch/tag creation in Subversion.Dec 5 2015, 9:07 PM
epriestley retitled this revision from Add "Is merge commit?" to commit actions in Herald to Add "Is merge commit?" to commit fields in Herald.
epriestley edited edge metadata.

Ah, yes.

chad accepted this revision.Dec 5 2015, 9:07 PM
chad edited edge metadata.
Closed by commit rP2353121dee77: Add "Is merge commit?" to commit fields in Herald (authored by epriestley, committed by epriestley). · Explain WhyDec 5 2015, 9:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
diffusion/
herald/
20 lines
37 lines

Diff 35516

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitMergeHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/HeraldCommitAdapter.php

Loading...
Phabricator · Built by Phacility