Page MenuHomePhabricator

Add "Is merge commit?" to commit fields in Herald
ClosedPublic

Authored by epriestley on Dec 5 2015, 8:58 PM.
Tags
None
Referenced Files
F15395694: D14685.id.diff
Sun, Mar 16, 9:00 AM
F15381077: D14685.diff
Fri, Mar 14, 5:45 AM
F15354251: D14685.diff
Tue, Mar 11, 2:52 AM
Unknown Object (File)
Mon, Mar 3, 3:35 PM
Unknown Object (File)
Feb 19 2025, 5:37 PM
Unknown Object (File)
Feb 19 2025, 5:37 PM
Unknown Object (File)
Feb 19 2025, 5:32 AM
Unknown Object (File)
Feb 9 2025, 12:00 AM
Subscribers
Tokens
"Like" token, awarded by avivey.

Details

Summary

Fixes T5788. We already have this as a pre-commit field, add it as a post-commit field too.

Test Plan

Ran this rule on a merge commit. Also ran it on a non-merge commit. Both got the correct value.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add "Is merge commit?" to commit actions in Herald.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
avivey added a reviewer: avivey.
avivey added a subscriber: avivey.

The title should probably be "...rule in herald"?

This revision is now accepted and ready to land.Dec 5 2015, 9:07 PM
epriestley retitled this revision from Add "Is merge commit?" to commit actions in Herald to Add "Is merge commit?" to commit fields in Herald.
epriestley edited edge metadata.

Ah, yes.

chad edited edge metadata.
This revision was automatically updated to reflect the committed changes.