Page MenuHomePhabricator
Differential D14647

Remove `short_tags` option from XHPAST
ClosedPublic
Actions

Authored by joshuaspence on Dec 2 2015, 9:48 PM.
Tags
None
Referenced Files
F15507394: D14647.diff
Tue, Apr 15, 7:13 PM
F15507349: D14647.diff
Tue, Apr 15, 6:58 PM
F15484439: D14647.id35430.diff
Wed, Apr 9, 6:16 PM
F15478925: D14647.diff
Tue, Apr 8, 4:01 AM
F15466015: D14647.id35436.diff
Thu, Apr 3, 12:50 AM
F15426240: D14647.diff
Mar 23 2025, 7:50 AM
F15420610: D14647.id35430.diff
Mar 21 2025, 3:25 PM
F15415126: D14647.id35436.diff
Mar 20 2025, 4:13 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHUa8143ced646d: Remove `short_tags` option from XHPAST
Summary

This option is hardcoded to true anyway.

Test Plan

Ran unit tests.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9241
Build 10949: Run Core Tests
Build 10948: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 35430.Dec 2 2015, 9:48 PM
joshuaspence retitled this revision from to Remove `short_tags` option from XHPAST.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 2 2015, 9:49 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Dec 2 2015, 10:15 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 2 2015, 10:15 PM
joshuaspence mentioned this in D14537: Tidying of XHPAST.Dec 2 2015, 10:46 PM
Closed by commit rPHUa8143ced646d: Remove `short_tags` option from XHPAST (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 2 2015, 10:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
xhpast/
bin/
2 lines
support/
xhpast/
2 lines
6 lines
2 lines
2224 lines
3 lines

Diff 35430

View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

Loading...
View Options

support/xhpast/ast.hpp

Loading...
View Options

support/xhpast/scanner.l

Loading...
View Options

support/xhpast/scanner.lex.hpp

Loading...
View Options

support/xhpast/scanner.lex.cpp

Loading...
View Options

support/xhpast/xhpast.cpp

Loading...
Phabricator · Built by Phacility