Differential D14639

Add missing test data
AbandonedPublic
Actions

Authored by joshuaspence on Dec 2 2015, 8:55 PM.

Tags

None

Referenced Files

	F14096708: D14639.diff
	Tue, Nov 26, 4:53 AM

	Unknown Object (File)
	Thu, Nov 14, 4:31 AM

	Unknown Object (File)
	Sat, Nov 9, 10:51 AM

	Unknown Object (File)
	Sat, Nov 9, 10:51 AM

	Unknown Object (File)
	Tue, Nov 5, 10:04 PM

	Unknown Object (File)
	Fri, Nov 1, 8:46 PM

	Unknown Object (File)
	Oct 19 2024, 7:47 AM

	Unknown Object (File)
	Oct 18 2024, 7:47 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Summary

D14627 added an additional test case but did not add the expected outpud data for this test case.

Test Plan

Actually ran the unit tests this time.

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 9228
Build 10927: Run Core Tests
Build 10926: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 35417.Dec 2 2015, 8:55 PM

joshuaspence retitled this revision from to Add missing test data.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 2 2015, 8:55 PM

Herald added a subscriber: Korvin. · View Herald Transcript

See rPHU0b37f385b8cd instead.

joshuaspence mentioned this in rPHU0b37f385b8cd: Fix build for a test case with no test data..Dec 5 2015, 12:23 AM

Oh, sorry, totally missed this. I think not requiring the data is fine, this test case doesn't need 6K lines of JSON to serve the purpose it's supposed to serve.

In D14639#166440, @epriestley wrote:

Oh, sorry, totally missed this. I think not requiring the data is fine, this test case doesn't need 6K lines of JSON to serve the purpose it's supposed to serve.

Yeah, agreed.

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

__tests__/

data/

yyinitdepth.php.test

5861 lines

Diff 35417

src/parser/xhpast/tests/data/yyinitdepth.php.test

Loading...