Page MenuHomePhabricator
Differential D14611

Minor fix for typecast linter rule
ClosedPublic
Actions

Authored by joshuaspence on Nov 30 2015, 7:40 PM.
Tags
None
Referenced Files
F14081389: D14611.diff
Fri, Nov 22, 7:34 PM
F14080657: D14611.diff
Fri, Nov 22, 3:41 PM
Unknown Object (File)
Mon, Nov 18, 8:29 AM
Unknown Object (File)
Thu, Nov 14, 1:47 AM
Unknown Object (File)
Sat, Nov 9, 5:01 PM
Unknown Object (File)
Fri, Nov 8, 7:59 PM
Unknown Object (File)
Fri, Nov 8, 7:59 PM
Unknown Object (File)
Fri, Nov 8, 7:59 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC09052d52470d: Minor fix for typecast linter rule
Summary

intval($x, $y) cannot be safely changed to (int)$x if $y != 10.

Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 9157
Build 10813: Run Core Tests
Build 10812: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
70 msArcanistCurlyBraceArrayIndexXHPASTLinterRuleTestCase::Unknown Unit Message ("")
15 msArcanistCurlyBraceArrayIndexXHPASTLinterRuleTestCase::Unknown Unit Message ("")
94 msArcanistFunctionCallShouldBeTypeCastXHPASTLinterRuleTestCase::Unknown Unit Message ("")
19 msArcanistFunctionCallShouldBeTypeCastXHPASTLinterRuleTestCase::Unknown Unit Message ("")
564 msArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
View Full Test Results (5 Failed · 290 Passed · 46 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 35347.Nov 30 2015, 7:40 PM
joshuaspence retitled this revision from to Minor fix for typecast linter rule.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 30 2015, 7:40 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Nov 30 2015, 7:41 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 30 2015, 7:41 PM
joshuaspence updated this revision to Diff 35369.Dec 1 2015, 10:32 AM
joshuaspence edited edge metadata.

Fix failing test

joshuaspence added inline comments.Dec 1 2015, 7:31 PM
src/lint/linter/xhpast/rules/ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule.php
31

We have a whole bunch of issues generally with case-insensitive class and function names. One way that we could improve handling of this is to introduce a CaseInsensitiveArray class, which should be case-insensitive but case-preserving.

Closed by commit rARC09052d52470d: Minor fix for typecast linter rule (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 2 2015, 3:16 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
xhpast/
rules/
16 lines
__tests__/
function-call-should-be-type-cast/
12 lines

Diff 35347

View Options

src/lint/linter/xhpast/rules/ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/function-call-should-be-type-cast/base.lint-test

Loading...
Phabricator · Built by Phacility