intval($x, $y) cannot be safely changed to (int)$x if $y != 10.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rARC09052d52470d: Minor fix for typecast linter rule
Added test cases.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
src/lint/linter/xhpast/rules/ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule.php | ||
---|---|---|
31 | We have a whole bunch of issues generally with case-insensitive class and function names. One way that we could improve handling of this is to introduce a CaseInsensitiveArray class, which should be case-insensitive but case-preserving. |