Page MenuHomePhabricator

Partially revert D14511 to fix "INLINE COMMENTS" in mail
ClosedPublic

Authored by epriestley on Nov 28 2015, 9:33 PM.
Tags
None
Referenced Files
F14052235: D14589.diff
Fri, Nov 15, 7:42 AM
F14037677: D14589.diff
Sun, Nov 10, 6:17 PM
F14029608: D14589.diff
Fri, Nov 8, 8:50 PM
F14029207: D14589.id35295.diff
Fri, Nov 8, 7:59 PM
F14026657: D14589.id35292.diff
Fri, Nov 8, 1:54 AM
F14026656: D14589.id.diff
Fri, Nov 8, 1:54 AM
F14024933: D14589.diff
Thu, Nov 7, 1:26 PM
F14001840: D14589.diff
Fri, Oct 25, 12:29 PM
Subscribers
Tokens
"Pterodactyl" token, awarded by joshuaspence.

Details

Summary

Ref T9845. In Differential, this is not a remarkup block -- it's a mail section. addTextSection() has special magic behavior when handed a prebuilt section since D9375.

Swapping to addRemarkupSection() causes the error in T9845 and renders nothing in the comment section.

Even if it were a block of text, it would not be appropriate to add it as remarkup. This would incorrectly render comments in files like __init__.py, which are common on Python (the filename would render as "__init__.py"). Okay that's a bad example since it works fine but, uh, a file named T123 would be no good or whatever.

I'll realign T9845 to clean this up and fix it more durably.

Test Plan

Sent myself some mail with inline comments, saw them in the mail.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Partially revert D14511 to fix "INLINE COMMENTS" in mail.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, joshuaspence.
epriestley updated this object.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 28 2015, 9:40 PM
This revision was automatically updated to reflect the committed changes.

I tested the change and this partially works, now I see the email shows like the following:
INLINE COMMENTS

urls.py:5 test inline comments.

It used to have the following format and also have the context of the inline comments:

INLINE COMMENTS

================
Comment at: urls.py:5

........................
........................
........................


test inline comments.

The extra context is controlled by the metamta.differential.unified-comment-context setting. Turn it back on to restore the context.

Indeed, it works after I turned it back on. Thanks!