Page MenuHomePhabricator
Differential D14576

Remove WILLEDITTASK and DIDEDITTASK events
ClosedPublic
Actions

Authored by epriestley on Nov 26 2015, 3:08 PM.
Tags
None
Referenced Files
F13096824: D14576.id35267.diff
Thu, Apr 25, 7:02 PM
F13090921: D14576.diff
Thu, Apr 25, 2:38 AM
Unknown Object (File)
Fri, Apr 19, 3:52 PM
Unknown Object (File)
Fri, Apr 19, 10:54 AM
Unknown Object (File)
Sat, Apr 13, 12:00 AM
Unknown Object (File)
Mon, Apr 1, 4:25 AM
Unknown Object (File)
Mar 10 2024, 7:43 AM
Unknown Object (File)
Mar 5 2024, 2:27 AM
View All Files
Subscribers
Krenair

Details

Reviewers
chad
Maniphest Tasks
T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events
Commits
Restricted Diffusion Commit
rPfb3c18349ec1: Remove WILLEDITTASK and DIDEDITTASK events
Summary

Fixes T9851. I'll hold this for a while to give users some time to update per T9860.

Test Plan

Edited a task via:

  • Conduit
  • Comments field
  • Edit form
  • New task form

Diff Detail

Repository
rP Phabricator
Branch
willedit2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9076
Build 10686: Run Core Tests
Build 10685: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35267.Nov 26 2015, 3:08 PM
epriestley retitled this revision from to Remove WILLEDITTASK and DIDEDITTASK events.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events.
epriestley mentioned this in T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events.Nov 26 2015, 3:27 PM
chad accepted this revision.Nov 26 2015, 4:32 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 26 2015, 4:32 PM
Krenair added a subscriber: Krenair.Dec 1 2015, 8:22 PM
Closed by commit rPfb3c18349ec1: Remove WILLEDITTASK and DIDEDITTASK events (authored by epriestley, committed by epriestley). · Explain WhyDec 9 2015, 3:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
conduit/
25 lines
controller/
28 lines
25 lines
docs/
user/
userguide/
40 lines
infrastructure/
events/
constant/
3 lines

Diff 35267

View Options

src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskEditController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTransactionSaveController.php

Loading...
View Options

src/docs/user/userguide/events.diviner

Loading...
View Options

src/infrastructure/events/constant/PhabricatorEventType.php

Loading...
Phabricator · Built by Phacility