Page MenuHomePhabricator

Add a linter rule for `*val` functions
ClosedPublic

Authored by joshuaspence on Nov 25 2015, 7:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 7, 4:44 AM
Unknown Object (File)
Thu, Mar 7, 4:44 AM
Unknown Object (File)
Thu, Mar 7, 4:44 AM
Unknown Object (File)
Thu, Mar 7, 3:57 AM
Unknown Object (File)
Wed, Mar 6, 5:26 AM
Unknown Object (File)
Feb 15 2024, 6:45 PM
Unknown Object (File)
Feb 14 2024, 12:34 PM
Unknown Object (File)
Jan 20 2024, 9:22 PM
Subscribers

Details

Summary

Type casts should be used instead of calls to the *val functions as function calls impose additional overhead.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Add a linter rule for `*val` functions.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

I think "for consistency" is a stronger motivator here than overhead, but rule itself is fine.

This revision is now accepted and ready to land.Nov 28 2015, 2:46 PM
joshuaspence edited edge metadata.

Add another test case

This revision was automatically updated to reflect the committed changes.