Paths

Table of Contentst

AphrontFormTokenizerControl::readValueFromRequest
Needs ReviewPublic
Actions

Authored by avivey on Nov 24 2015, 12:02 AM.

Tags

None

Referenced Files

	F18743590: D14565.diff
	Oct 3 2025, 12:11 AM

	F18731150: D14565.diff
	Sep 30 2025, 2:01 PM

	F18712876: D14565.id.diff
	Sep 29 2025, 5:33 AM

	F18699878: D14565.id35229.diff
	Sep 27 2025, 1:52 PM

	F18499359: D14565.diff
	Sep 4 2025, 7:41 PM

	F18085350: D14565.diff
	Aug 5 2025, 7:10 PM

	F17874399: D14565.diff
	Jul 28 2025, 5:46 PM

	Unknown Object (File)
	Jul 2 2025, 1:18 PM

View All Files

Subscribers

epriestley

Details

Reviewers

None

Group Reviewers

Blessed Reviewers

Summary

Not sure if deprecated or new... But it was failing when used in multi-page form.

Test Plan

Use $form->readFromRequest($request) with a tokenized field.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9038
Build 10626: Run Core Tests
Build 10625: arc lint + arc unit

Event Timeline

avivey updated this revision to Diff 35229.Nov 24 2015, 12:02 AM

avivey retitled this revision from to AphrontFormTokenizerControl::readValueFromRequest.

avivey updated this object.

avivey edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 24 2015, 12:02 AM

Herald added a subscriber: epriestley. · View Herald Transcript

This isn't enough; When going "<< back", the value becomes string again.

Maybe T7029?

Might be close; I hit the form button for "back", and looked in darkconsole to see the value is a string. Stopped exploring at that point ATM.

Revision Contents
Changeset List

Path

Size

src/

view/

form/

control/

AphrontFormTokenizerControl.php

5 lines

Diff 35229

View Options

src/view/form/control/AphrontFormTokenizerControl.php

AphrontFormTokenizerControl::readValueFromRequestNeeds ReviewPublicActions