Paths

Table of Contentst

AphrontFormTokenizerControl::readValueFromRequest
Needs ReviewPublic
Actions

Authored by avivey on Nov 24 2015, 12:02 AM.

Tags

None

Referenced Files

	F15535546: D14565.id35229.diff
	Thu, Apr 24, 5:42 AM

	F15512581: D14565.id35229.diff
	Thu, Apr 17, 11:42 AM

	F15492733: D14565.id35229.diff
	Sat, Apr 12, 5:44 PM

	F15491467: D14565.id.diff
	Sat, Apr 12, 3:52 AM

	F15491175: D14565.diff
	Fri, Apr 11, 11:56 PM

	Unknown Object (File)
	Mar 3 2025, 5:15 PM

	Unknown Object (File)
	Feb 8 2025, 11:52 PM

	Unknown Object (File)
	Feb 8 2025, 11:52 PM

View All Files

Subscribers

epriestley

Details

Reviewers

None

Group Reviewers

Blessed Reviewers

Summary

Not sure if deprecated or new... But it was failing when used in multi-page form.

Test Plan

Use $form->readFromRequest($request) with a tokenized field.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9038
Build 10626: Run Core Tests
Build 10625: arc lint + arc unit

Event Timeline

avivey updated this revision to Diff 35229.Nov 24 2015, 12:02 AM

avivey retitled this revision from to AphrontFormTokenizerControl::readValueFromRequest.

avivey updated this object.

avivey edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 24 2015, 12:02 AM

Herald added a subscriber: epriestley. · View Herald Transcript

This isn't enough; When going "<< back", the value becomes string again.

Maybe T7029?

Might be close; I hit the form button for "back", and looked in darkconsole to see the value is a string. Stopped exploring at that point ATM.

Revision Contents
Changeset List

Path

Size

src/

view/

form/

control/

AphrontFormTokenizerControl.php

5 lines

Diff 35229

View Options

src/view/form/control/AphrontFormTokenizerControl.php

AphrontFormTokenizerControl::readValueFromRequestNeeds ReviewPublicActions