Page MenuHomePhabricator
Differential D14561

Add a linter rule for `interface` method bodies
ClosedPublic
Actions

Authored by joshuaspence on Nov 23 2015, 9:13 PM.
Tags
None
Referenced Files
F15410012: D14561.diff
Wed, Mar 19, 6:34 AM
F15403176: D14561.id35259.diff
Tue, Mar 18, 2:07 AM
F15377347: D14561.id35259.diff
Thu, Mar 13, 8:40 AM
F15369446: D14561.id35259.diff
Wed, Mar 12, 6:45 AM
F15333553: D14561.id35259.diff
Sat, Mar 8, 3:00 AM
Unknown Object (File)
Jan 29 2025, 10:36 PM
Unknown Object (File)
Jan 29 2025, 10:36 PM
Unknown Object (File)
Jan 29 2025, 10:36 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC8183a458048c: Add a linter rule for `interface` method bodies
Summary

interface methods cannot contain a body. This construct will cause a fatal error:

PHP Fatal error:  Interface function X::Y() cannot contain body in /home/josh/workspace/github.com/phacility/arcanist/test.php on line 4
Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 35219.Nov 23 2015, 9:13 PM
joshuaspence retitled this revision from to Add a linter rule for `interface` method bodies.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 23 2015, 9:13 PM
Herald added a subscriber: Korvin. · View Herald Transcript
joshuaspence updated this object.Nov 23 2015, 9:20 PM
joshuaspence edited edge metadata.
epriestley accepted this revision.Nov 25 2015, 3:07 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 25 2015, 3:07 PM
Closed by commit rARC8183a458048c: Add a linter rule for `interface` method bodies (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 25 2015, 8:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
lint/
linter/
xhpast/
rules/
33 lines
__tests__/
10 lines
interface-method-body/
7 lines
6 lines

Diff 35259

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistInterfaceMethodBodyXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistInterfaceMethodBodyXHPASTLinterRuleTestCase.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/interface-method-body/body.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/interface-method-body/no-body.lint-test

Loading...
Phabricator · Built by Phacility