Page MenuHomePhabricator
Differential D14560

Add a linter rule for `abstract` methods containing a body
ClosedPublic
Actions

Authored by joshuaspence on Nov 23 2015, 9:05 PM.
Tags
None
Referenced Files
F17741568: D14560.diff
Mon, Jul 21, 9:32 AM
Unknown Object (File)
Jun 9 2025, 3:00 AM
Unknown Object (File)
May 1 2025, 8:35 PM
Unknown Object (File)
Apr 5 2025, 4:58 PM
Unknown Object (File)
Mar 24 2025, 3:01 AM
Unknown Object (File)
Mar 6 2025, 1:31 PM
Unknown Object (File)
Mar 3 2025, 8:05 AM
Unknown Object (File)
Feb 19 2025, 10:13 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC72d9013d29dc: Add a linter rule for `abstract` methods containing a body
Summary

abstract methods cannot contain a body.

PHP Fatal error:  Abstract function X::Y() cannot contain body in /home/josh/workspace/github.com/phacility/arcanist/test.php on line 4
Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 35218.Nov 23 2015, 9:05 PM
joshuaspence retitled this revision from to Add a linter rule for `abstract` methods containing a body.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 23 2015, 9:05 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Nov 23 2015, 9:09 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2015, 9:09 PM
joshuaspence updated this object.Nov 23 2015, 9:18 PM
joshuaspence edited edge metadata.
Closed by commit rARC72d9013d29dc: Add a linter rule for `abstract` methods containing a body (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 23 2015, 9:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35224

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/xhpast/ArcanistXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistAbstractMethodBodyXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistClassMustBeDeclaredAbstractXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/abstract-method-body/body.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/abstract-method-body/no-body.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/abstract-method-body/non-abstract.lint-test

Loading...
Phabricator · Built by Phacility